Collect framework dSYMs in test bundle debug dependencies #2742
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sewerynplazuk
requested review from
aaronsky,
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
sewerynplazuk
force-pushed
the
seweryn/test-bundle-frameworks-dsym-collection
branch
from
bc226fa to
30a01d0
Compare
sewerynplazuk
force-pushed
the
seweryn/test-bundle-frameworks-dsym-collection
branch
from
30a01d0 to
11e7ad8
Compare
brentleyjones
approved these changes
Jun 26, 2025
|
is it possible to add a test for this so it doesn’t regress? |
Makes sense. Let me see what I can do |
brentleyjones
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes dSYM collection for frameworks specified in the
frameworksattribute ofios_ui_testtargets.Currently, while framework binaries are properly made available to test targets, their corresponding dSYM files are not collected in the test bundle's debug symbol directory. This causes missing debug symbols when debugging test failures that involve framework code.
The fix ensures that dSYMs from framework dependencies are included alongside dSYMs from regular dependencies specified in the
depsattribute.