Collect framework dSYMs in test bundle debug dependencies (#2742)

This PR fixes dSYM collection for frameworks specified in the
`frameworks` attribute of `ios_ui_test` targets.

Currently, while framework binaries are properly made available to test
targets, their corresponding dSYM files are not collected in the test
bundle's debug symbol directory. This causes missing debug symbols when
debugging test failures that involve framework code.

The fix ensures that dSYMs from framework dependencies are included
alongside dSYMs from regular dependencies specified in the `deps`
attribute.

---------

Co-authored-by: Seweryn Plażuk <[email protected]>

Author: sewerynplazuk

apple/internal/testing/apple_test_bundle_support.bzl

@@ -412,9 +412,12 @@ def _apple_test_bundle_impl(*, ctx, product_type):
         debug_dependencies.append(test_host)
 
     if hasattr(ctx.attr, "frameworks"):
-        targets_to_avoid = list(ctx.attr.frameworks)
+        frameworks = list(ctx.attr.frameworks)
+        targets_to_avoid = frameworks
+        debug_dependencies.extend(frameworks)
     else:
         targets_to_avoid = []
+
     if bundle_loader:
         targets_to_avoid.append(bundle_loader)
 

test/starlark_tests/ios_ui_test_tests.bzl

@@ -137,6 +137,33 @@ def ios_ui_test_test_suite(name):
         tags = [name],
     )
 
+    analysis_output_group_info_files_test(
+        name = "{}_dsyms_output_group_files_with_fmwk_test".format(name),
+        target_under_test = "//test/starlark_tests/targets_under_test/ios:ui_test_with_fmwk",
+        output_group_name = "dsyms",
+        expected_outputs = [
+            "app.app.dSYM/Contents/Info.plist",
+            "app.app.dSYM/Contents/Resources/DWARF/app",
+            "ui_test_with_fmwk.xctest.dSYM/Contents/Info.plist",
+            "ui_test_with_fmwk.xctest.dSYM/Contents/Resources/DWARF/ui_test_with_fmwk",
+            "fmwk.framework.dSYM/Contents/Info.plist",
+            "fmwk.framework.dSYM/Contents/Resources/DWARF/fmwk",
+        ],
+        tags = [name],
+    )
+
+    apple_dsym_bundle_info_test(
+        name = "{}_apple_dsym_bundle_info_with_fmwk_test".format(name),
+        target_under_test = "//test/starlark_tests/targets_under_test/ios:ui_test_with_fmwk",
+        expected_direct_dsyms = ["dSYMs/ui_test_with_fmwk.xctest.dSYM"],
+        expected_transitive_dsyms = [
+            "dSYMs/app.app.dSYM",
+            "dSYMs/ui_test_with_fmwk.xctest.dSYM",
+            "dSYMs/fmwk.framework.dSYM",
+        ],
+        tags = [name],
+    )
+
     infoplist_contents_test(
         name = "{}_base_bundle_id_derived_bundle_id_plist_test".format(name),
         target_under_test = "//test/starlark_tests/targets_under_test/ios:ui_test_with_base_bundle_id_derived_bundle_id",