ARROW-10905: [Python] Add support for Python 3.9 Windows wheels #8916

terencehonles · 2020-12-14T19:33:37Z

Picking back up from #8386 in case I can handle this or someone else wants to work off of it. Likely will need to be updated based on #8881 / #8778.

github-actions · 2020-12-14T19:35:43Z

https://issues.apache.org/jira/browse/ARROW-10905

nealrichardson · 2021-01-08T17:31:42Z

#8881 has merged now so I think this needs to be rebased.

terencehonles · 2021-01-08T20:10:44Z

#8881 has merged now so I think this needs to be rebased.

Thanks for the heads up @nealrichardson

terencehonles · 2021-01-08T20:22:51Z

backing out Sutou Kouhei's changes temporarily to see where things stand without the subsequent modifications.

terencehonles · 2021-01-08T20:23:39Z

@github-actions crossbow submit wheel-win-cp38 wheel-win-cp39 conda-win-vs2017-py39

github-actions · 2021-01-08T20:24:33Z

Revision: dbbb36c78c17674912f02b1c0227cadc2e8e06a5

Submitted crossbow builds: ursa-labs/crossbow @ actions-849

Task	Status
conda-win-vs2017-py39
wheel-win-cp38
wheel-win-cp39

terencehonles · 2021-01-08T20:30:05Z

@github-actions crossbow submit wheel-win-cp39

github-actions · 2021-01-08T20:31:43Z

Revision: 5cdc1d90d1b5a66b79b161ca9738351753e6b418

Submitted crossbow builds: ursa-labs/crossbow @ actions-850

Task	Status
wheel-win-cp39

terencehonles · 2021-01-08T21:07:05Z

@github-actions crossbow submit wheel-win-cp39

github-actions · 2021-01-08T21:08:12Z

Revision: abb3bc027c5608ff59a24969ff21f25380935752

Submitted crossbow builds: ursa-labs/crossbow @ actions-851

Task	Status
wheel-win-cp39

terencehonles · 2021-01-08T21:22:27Z

@github-actions crossbow submit wheel-win-cp39

github-actions · 2021-01-08T21:23:22Z

Revision: d4afd67e24eb5bbd0d525352db35af6393ceab76

Submitted crossbow builds: ursa-labs/crossbow @ actions-852

Task	Status
wheel-win-cp39

terencehonles · 2021-01-08T21:27:25Z

@github-actions crossbow submit wheel-win-cp39

github-actions · 2021-01-08T21:28:37Z

Revision: 3d641a16c261d8fba103958606fa4b6f197b6483

Submitted crossbow builds: ursa-labs/crossbow @ actions-853

Task	Status
wheel-win-cp39

terencehonles · 2021-01-08T21:46:26Z

@github-actions crossbow submit wheel-win-cp36m wheel-win-cp37m wheel-win-cp38

github-actions · 2021-01-08T21:47:25Z

Revision: 3d641a16c261d8fba103958606fa4b6f197b6483

Submitted crossbow builds: ursa-labs/crossbow @ actions-855

Task	Status
wheel-win-cp36m
wheel-win-cp37m
wheel-win-cp38

terencehonles · 2021-01-09T04:52:22Z

@github-actions crossbow submit wheel-win-* conda-win-*

github-actions · 2021-01-09T04:53:14Z

Revision: 774ccd0e8f130dac9bef2debecad8b59f993cb15

Submitted crossbow builds: ursa-labs/crossbow @ actions-859

Task	Status
conda-win-vs2017-py36-r36
conda-win-vs2017-py37-r40
conda-win-vs2017-py38
conda-win-vs2017-py39
wheel-win-cp36m
wheel-win-cp37m
wheel-win-cp38
wheel-win-cp39

terencehonles · 2021-01-09T05:12:18Z

@github-actions crossbow submit wheel-win-cp36m

github-actions · 2021-01-09T05:13:12Z

Revision: e218e7e0e81fdff71a0e9f573c550adade797199

Submitted crossbow builds: ursa-labs/crossbow @ actions-860

Task	Status
wheel-win-cp36m

dev/tasks/python-wheels/win-build.bat

terencehonles · 2021-01-09T07:33:16Z

@github-actions crossbow submit wheel-win-cp36m

github-actions · 2021-01-09T07:34:20Z

Revision: 5b0c9f0a210bcbdb9a04e069bbfc4ba9ceccf0b6

Submitted crossbow builds: ursa-labs/crossbow @ actions-862

Task	Status
wheel-win-cp36m

terencehonles · 2021-01-09T20:23:30Z

@github-actions crossbow submit wheel-win-cp36m

github-actions · 2021-01-09T20:24:26Z

Revision: 6adf5c21621af57987a605d0fc97eed111706fcb

Submitted crossbow builds: ursa-labs/crossbow @ actions-863

Task	Status
wheel-win-cp36m

terencehonles · 2021-01-09T20:38:02Z

@github-actions crossbow submit wheel-win-* conda-win-*

github-actions · 2021-01-09T20:39:11Z

Revision: 56c378b

Submitted crossbow builds: ursa-labs/crossbow @ actions-864

Task	Status
conda-win-vs2017-py36-r36
conda-win-vs2017-py37-r40
conda-win-vs2017-py38
conda-win-vs2017-py39
wheel-win-cp36m
wheel-win-cp37m
wheel-win-cp38
wheel-win-cp39

terencehonles · 2021-01-09T20:41:01Z

@xhochy when you get a chance it looks like #8881 did not fix building on Python 3.6 as with my change and without my change (master) both seem to fail on finding OpenSSL.

I'll try to see if I can poke around further, but not sure how far I can get.

terencehonles · 2021-01-09T21:08:04Z

@kou any chance you know what to do about:

  File "arrow/dev/tasks/crossbow.py", line 1662, in upload_artifacts
    tag_name=tag, target_commitish=sha, method=method, patterns=patterns
  File "arrow/dev/tasks/crossbow.py", line 460, in github_overwrite_release_assets
    repo = self.as_github_repo()
  File "arrow/dev/tasks/crossbow.py", line 384, in as_github_repo
    self._github_repo = github.repository(username, reponame)
  File "C:\Miniconda\lib\site-packages\github3\github.py", line 1981, in repository
    json = self._json(self._get(url), 200)
  File "C:\Miniconda\lib\site-packages\github3\models.py", line 156, in _json
    raise exceptions.error_for(response)
github3.exceptions.AuthenticationFailed: 401 Bad credentials

from https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=22650&view=logs&j=4c86bc1b-1091-5192-4404-c74dfaad23e7&t=ec99a26b-0264-5e86-36fb-9cfd0ca0f9f3&l=37 (conda builds)

I probably didn't need to rebuild everything since that step will probably fail across the board (I'll check each of them since I hadn't done that in #8916 (comment) )

xhochy · 2021-01-09T21:31:36Z

@xhochy when you get a chance it looks like #8881 did not fix building on Python 3.6 as with my change and without my change (master) both seem to fail on finding OpenSSL.

I'll try to see if I can poke around further, but not sure how far I can get.

The OpenSSL issue is not problem. This just skips the SSL-supporting part of thrift, we don't need that. I actually fail to parse the log to find what is actually the issue though.

xhochy · 2021-01-09T21:33:03Z

@xhochy when you get a chance it looks like #8881 did not fix building on Python 3.6 as with my change and without my change (master) both seem to fail on finding OpenSSL.
I'll try to see if I can poke around further, but not sure how far I can get.

The OpenSSL issue is not problem. This just skips the SSL-supporting part of thrift, we don't need that. I actually fail to parse the log to find what is actually the issue though.

OpenSSL is an issue but for gRPC!

dev/tasks/python-wheels/win-build.bat

kou · 2021-01-09T22:21:57Z

@kou any chance you know what to do about:

It seems that we need to update a secret variable registered in https://dev.azure.com/ursa-labs/crossbow/ but I don't have permission to update it. It seems that we don't care about conda-win-* tasks in this pull request because we don't touch anything for conda-win-* in this pull request.

kou · 2021-01-09T22:23:10Z

It may be better that we wait for #9096 because it uses vcpkg instead of conda.
It doesn't have the OpenSSL problem: #9096 (comment)

Co-authored-by: Uwe L. Korn <[email protected]>

terencehonles · 2021-01-10T00:07:26Z

@github-actions crossbow submit wheel-win-cp36m wheel-win-cp39

terencehonles · 2021-01-10T00:08:11Z

It may be better that we wait for #9096 because it uses vcpkg instead of conda.
It doesn't have the OpenSSL problem: #9096 (comment)

Ok, I'll just test out the suggestion. Not sure when @kszucs plans on trying to get #9096 in.

github-actions · 2021-01-10T00:08:16Z

Revision: 5df8d6b

Submitted crossbow builds: ursa-labs/crossbow @ actions-865

Task	Status
wheel-win-cp36m
wheel-win-cp39

kszucs · 2021-01-11T13:30:06Z

@kou any chance you know what to do about:

It seems that we need to update a secret variable registered in https://dev.azure.com/ursa-labs/crossbow/ but I don't have permission to update it. It seems that we don't care about conda-win-* tasks in this pull request because we don't touch anything for conda-win-* in this pull request.

I updated the secret and also invited you to the project.

terencehonles · 2021-01-11T17:06:56Z

@github-actions crossbow submit wheel-win-cp36m

github-actions · 2021-01-11T19:12:00Z

Revision: c532cd1

Submitted crossbow builds: ursa-labs/crossbow @ actions-871

Task	Status
wheel-win-cp36m

kszucs · 2021-01-15T07:07:09Z

Superseded by #9096.

github-actions bot added the Component: C++ label Dec 14, 2020

terencehonles force-pushed the arrow-10905 branch from 56a7e55 to dbbb36c Compare January 8, 2021 20:21

terencehonles force-pushed the arrow-10905 branch from 5cdc1d9 to abb3bc0 Compare January 8, 2021 21:06

terencehonles force-pushed the arrow-10905 branch from abb3bc0 to d4afd67 Compare January 8, 2021 21:22

terencehonles force-pushed the arrow-10905 branch from 3d641a1 to 774ccd0 Compare January 9, 2021 04:51

terencehonles force-pushed the arrow-10905 branch from 774ccd0 to e218e7e Compare January 9, 2021 05:11

kou reviewed Jan 9, 2021

View reviewed changes

dev/tasks/python-wheels/win-build.bat Outdated Show resolved Hide resolved

terencehonles force-pushed the arrow-10905 branch from e218e7e to 5b0c9f0 Compare January 9, 2021 06:48

terencehonles force-pushed the arrow-10905 branch from 5b0c9f0 to 6adf5c2 Compare January 9, 2021 20:23

ARROW-10905: [Python] Add support for Python 3.9 Windows wheels

56c378b

terencehonles force-pushed the arrow-10905 branch from 6adf5c2 to 56c378b Compare January 9, 2021 20:37

xhochy reviewed Jan 9, 2021

View reviewed changes

dev/tasks/python-wheels/win-build.bat Outdated Show resolved Hide resolved

Update dev/tasks/python-wheels/win-build.bat

5df8d6b

Co-authored-by: Uwe L. Korn <[email protected]>

set lower bound for VS

c532cd1

kszucs closed this Jan 15, 2021

terencehonles deleted the arrow-10905 branch January 15, 2021 17:29

asfimport mentioned this pull request Jan 15, 2021

[Python] Add support for Python 3.9 windows wheels #26837

Closed

ARROW-10905: [Python] Add support for Python 3.9 Windows wheels #8916

ARROW-10905: [Python] Add support for Python 3.9 Windows wheels #8916

Uh oh!

Conversation

terencehonles commented Dec 14, 2020

Uh oh!

github-actions bot commented Dec 14, 2020

Uh oh!

nealrichardson commented Jan 8, 2021

Uh oh!

terencehonles commented Jan 8, 2021

Uh oh!

terencehonles commented Jan 8, 2021

Uh oh!

terencehonles commented Jan 8, 2021

Uh oh!

github-actions bot commented Jan 8, 2021

Uh oh!

terencehonles commented Jan 8, 2021

Uh oh!

github-actions bot commented Jan 8, 2021

Uh oh!

terencehonles commented Jan 8, 2021

Uh oh!

github-actions bot commented Jan 8, 2021

Uh oh!

terencehonles commented Jan 8, 2021

Uh oh!

github-actions bot commented Jan 8, 2021

Uh oh!

terencehonles commented Jan 8, 2021

Uh oh!

github-actions bot commented Jan 8, 2021

Uh oh!

terencehonles commented Jan 8, 2021

Uh oh!

github-actions bot commented Jan 8, 2021

Uh oh!

terencehonles commented Jan 9, 2021

Uh oh!

github-actions bot commented Jan 9, 2021

Uh oh!

terencehonles commented Jan 9, 2021

Uh oh!

github-actions bot commented Jan 9, 2021

Uh oh!

Uh oh!

terencehonles commented Jan 9, 2021

Uh oh!

github-actions bot commented Jan 9, 2021

Uh oh!

terencehonles commented Jan 9, 2021

Uh oh!

github-actions bot commented Jan 9, 2021

Uh oh!

terencehonles commented Jan 9, 2021

Uh oh!

github-actions bot commented Jan 9, 2021

Uh oh!

terencehonles commented Jan 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terencehonles commented Jan 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xhochy commented Jan 9, 2021

Uh oh!

xhochy commented Jan 9, 2021

Uh oh!

Uh oh!

kou commented Jan 9, 2021

Uh oh!

kou commented Jan 9, 2021

Uh oh!

terencehonles commented Jan 10, 2021

Uh oh!

terencehonles commented Jan 10, 2021

Uh oh!

github-actions bot commented Jan 10, 2021

Uh oh!

terencehonles commented Jan 9, 2021 •

edited

Loading

terencehonles commented Jan 9, 2021 •

edited

Loading