ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds #8881

xhochy · 2020-12-09T17:33:07Z

No description provided.

xhochy · 2020-12-09T17:33:22Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-09T17:37:53Z

Revision: 19f504ae0ef417c0ee6003973837862efc64f7a2

Submitted crossbow builds: ursa-labs/crossbow @ actions-754

Task	Status
wheel-win-cp38

xhochy · 2020-12-09T17:51:23Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-09T18:03:07Z

Revision: 6e531ba7d6a5958384b96a104bbc6c7abc479dd9

Submitted crossbow builds: ursa-labs/crossbow @ actions-755

Task	Status
wheel-win-cp38

xhochy · 2020-12-09T19:09:03Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-09T19:12:03Z

Revision: d07f3c506208255835834caf059a4ee143d09598

Submitted crossbow builds: ursa-labs/crossbow @ actions-757

Task	Status
wheel-win-cp38

xhochy · 2020-12-10T08:19:48Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-10T08:23:09Z

Revision: b723f0cd2bdcf729d581250600164e6f265c3dd5

Submitted crossbow builds: ursa-labs/crossbow @ actions-760

Task	Status
wheel-win-cp38

xhochy · 2020-12-10T09:21:23Z

@github-actions crossbow submit wheel-win-cp38

xhochy · 2020-12-10T09:53:06Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-10T09:54:53Z

Revision: bdb5df7887dd34bdaa15e583b934d498019278b8

Submitted crossbow builds: ursa-labs/crossbow @ actions-761

Task	Status
wheel-win-cp38

xhochy · 2020-12-10T10:14:35Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-10T10:36:09Z

Revision: 4d5d7c0cca7b593fea10560a28af69abd3ac19d9

Submitted crossbow builds: ursa-labs/crossbow @ actions-762

Task	Status
wheel-win-cp38

xhochy · 2020-12-10T11:11:46Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-10T11:13:22Z

Revision: d1dea6a417eba6131b3b5400fe4ce600065ade77

Submitted crossbow builds: ursa-labs/crossbow @ actions-763

Task	Status
wheel-win-cp38

xhochy · 2020-12-10T12:30:58Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-10T12:32:34Z

Revision: 774d91c8cabaee63d5da57269d761acea4fb3f68

Submitted crossbow builds: ursa-labs/crossbow @ actions-764

Task	Status
wheel-win-cp38

xhochy · 2020-12-10T13:19:42Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-10T13:25:52Z

Revision: 547a693955dc3fa9d15793468c9431e86d6b7bab

Submitted crossbow builds: ursa-labs/crossbow @ actions-765

Task	Status
wheel-win-cp38

xhochy · 2020-12-10T14:56:53Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-10T14:59:19Z

Revision: d548b72b57149d0b4267c4cd0754129c9623861d

Submitted crossbow builds: ursa-labs/crossbow @ actions-766

Task	Status
wheel-win-cp38

xhochy · 2020-12-11T10:01:44Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-11T10:03:06Z

Revision: 7a27bb2395cb119933eab29762e4567c0bd3508e

Submitted crossbow builds: ursa-labs/crossbow @ actions-775

Task	Status
wheel-win-cp38

xhochy · 2020-12-11T10:39:35Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-11T10:41:21Z

Revision: 7a27bb2395cb119933eab29762e4567c0bd3508e

Submitted crossbow builds: ursa-labs/crossbow @ actions-776

Task	Status
wheel-win-cp38

xhochy · 2020-12-11T11:30:58Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2020-12-11T11:32:30Z

Revision: 24258fd948531e3dc680e51dad1bcc5149c2a4bf

Submitted crossbow builds: ursa-labs/crossbow @ actions-777

Task	Status
wheel-win-cp38

Co-authored-by: Sutou Kouhei <[email protected]>

kszucs · 2021-01-07T14:52:22Z

It may need more scopes enabled, looking.

kszucs · 2021-01-07T14:55:59Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2021-01-07T15:17:40Z

Revision: 2367ec5

Submitted crossbow builds: ursa-labs/crossbow @ actions-832

Task	Status
wheel-win-cp38

nealrichardson · 2021-01-07T23:34:41Z

@kszucs can this be merged now?

kou · 2021-01-08T02:19:03Z

cpp/cmake_modules/ThirdpartyToolchain.cmake

+      re2::re2
+      PROPERTIES IMPORTED_LOCATION "${RE2_STATIC_LIB}" INTERFACE_INCLUDE_DIRECTORIES
+                 "${RE2_PREFIX}/include")
+  endif()


Can we remove this because we always add re2::re2 library at the above line.

kou · 2021-01-08T02:47:45Z

@github-actions crossbow submit wheel-win-cp38

github-actions · 2021-01-08T03:08:11Z

Revision: 393da6f

Submitted crossbow builds: ursa-labs/crossbow @ actions-843

Task	Status
wheel-win-cp38

kou · 2021-01-08T04:24:05Z

+1

github-actions bot added the Component: C++ label Dec 9, 2020

xhochy mentioned this pull request Dec 10, 2020

ARROW-10861: [Python] Update minimal NumPy version to 1.16.6 #8878

Closed

terencehonles mentioned this pull request Dec 10, 2020

ARROW-10224: [Python] Add support for Python 3.9 except macOS wheel and Windows wheel #8386

Closed

xhochy and others added 15 commits January 7, 2021 15:14

gRPC_PROTOBUF_PACKAGE_TYPE=CONFIG

9978976

More verbosity

b3f18e3

Fix lib-protobuf prefix

ccad653

Add ABSL_LIBRARIES to ARROW_FLIGHT_STATIC_LINK_LIBS

58ff773

Update absl

9f4848a

Add additional absl libs

6ffe53c

Install cython and setuptools-scm

e0886a1

Comment out bundled libs

57a0781

Cleanup

893e104

Autoformat/render all the things [automated commit]

57e99ad

Define re2::re2 in third party toolchain

06b556a

Autoformat/render all the things [automated commit]

4409ce2

ARROW_DEPENDENCY_USE_SHARED=OFF

b0f3dfd

Set values so that FindRE2 finds this too

1e76b46

Update cpp/cmake_modules/ThirdpartyToolchain.cmake

2367ec5

Co-authored-by: Sutou Kouhei <[email protected]>

xhochy force-pushed the windows-wheel branch from b594fde to 2367ec5 Compare January 7, 2021 14:14

kou reviewed Jan 8, 2021

View reviewed changes

kou added 2 commits January 8, 2021 11:45

Remove needless code

3dfc08b

Remove needless workaround

393da6f

kou closed this in 0ed34c8 Jan 8, 2021

xhochy deleted the windows-wheel branch January 8, 2021 15:00

asfimport mentioned this pull request Jan 8, 2021

[Python] Do not depend on conda-forge static libraries in Windows wheel builds #25480

Closed

ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds #8881

ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds #8881

Uh oh!

Conversation

xhochy commented Dec 9, 2020

Uh oh!

xhochy commented Dec 9, 2020

Uh oh!

github-actions bot commented Dec 9, 2020

Uh oh!

xhochy commented Dec 9, 2020

Uh oh!

github-actions bot commented Dec 9, 2020

Uh oh!

xhochy commented Dec 9, 2020

Uh oh!

github-actions bot commented Dec 9, 2020

Uh oh!

xhochy commented Dec 10, 2020

Uh oh!

github-actions bot commented Dec 10, 2020

Uh oh!

xhochy commented Dec 10, 2020

Uh oh!

xhochy commented Dec 10, 2020

Uh oh!

github-actions bot commented Dec 10, 2020

Uh oh!

xhochy commented Dec 10, 2020

Uh oh!

github-actions bot commented Dec 10, 2020

Uh oh!

xhochy commented Dec 10, 2020

Uh oh!

github-actions bot commented Dec 10, 2020

Uh oh!

xhochy commented Dec 10, 2020

Uh oh!

github-actions bot commented Dec 10, 2020

Uh oh!

xhochy commented Dec 10, 2020

Uh oh!

github-actions bot commented Dec 10, 2020

Uh oh!

xhochy commented Dec 10, 2020

Uh oh!

github-actions bot commented Dec 10, 2020

Uh oh!

xhochy commented Dec 11, 2020

Uh oh!

github-actions bot commented Dec 11, 2020

Uh oh!

xhochy commented Dec 11, 2020

Uh oh!

github-actions bot commented Dec 11, 2020

Uh oh!

xhochy commented Dec 11, 2020

Uh oh!

github-actions bot commented Dec 11, 2020

Uh oh!

kszucs commented Jan 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszucs commented Jan 7, 2021

Uh oh!

github-actions bot commented Jan 7, 2021

Uh oh!

nealrichardson commented Jan 7, 2021

Uh oh!

kou Jan 8, 2021

Choose a reason for hiding this comment

Uh oh!

kou commented Jan 8, 2021

Uh oh!

github-actions bot commented Jan 8, 2021

Uh oh!

kou commented Jan 8, 2021

Uh oh!

Reviewers

Assignees

kszucs commented Jan 7, 2021 •

edited

Loading