Skip to content

ARROW-10861: [Python] Update minimal NumPy version to 1.16.6 #8878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xhochy wants to merge 2 commits into from
Closed

ARROW-10861: [Python] Update minimal NumPy version to 1.16.6 #8878

xhochy wants to merge 2 commits into from

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented Dec 9, 2020

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 9, 2020

https://issues.apache.org/jira/browse/ARROW-10861

@kou
Copy link
Member

kou commented Dec 9, 2020

@github-actions crossbow submit -g wheel

@github-actions
Copy link

github-actions bot commented Dec 9, 2020

Revision: ab43613e8c91eb50998ac42a8fa356d76f98e3b1

Submitted crossbow builds: ursa-labs/crossbow @ actions-756

Task Status
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-osx-high-sierra-cp36m TravisCI
wheel-osx-high-sierra-cp37m TravisCI
wheel-osx-high-sierra-cp38 TravisCI
wheel-osx-mavericks-cp36m TravisCI
wheel-osx-mavericks-cp37m TravisCI
wheel-osx-mavericks-cp38 TravisCI
wheel-win-cp36m Github Actions
wheel-win-cp37m Github Actions
wheel-win-cp38 Github Actions

@kou
Copy link
Member

kou commented Dec 9, 2020

It seems that we can't use numpy>=1.16.6 with vs2015_runtime<14.16.

@xhochy
Copy link
Member Author

xhochy commented Dec 10, 2020

Windows Wheels in general are currently broken. I have a WIP PR in #8881 to have everything build from BUNDLED instead of using conda-forge packages.

jorisvandenbossche
jorisvandenbossche reviewed Dec 10, 2020
View reviewed changes
@terencehonles terencehonles mentioned this pull request Dec 11, 2020
Closed
@github-actions github-actions bot added the needs-rebase A PR that needs to be rebased by the author label Dec 13, 2020
@xhochy xhochy mentioned this pull request Dec 14, 2020
Closed
@pitrou
Copy link
Member

pitrou commented Dec 14, 2020

I have no problem with this PR, but it needs rebasing and fixing conflicts.

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jan 11, 2021

@xhochy do we still want to do this for pyarrow 3.0 ?

@xhochy
Copy link
Member Author

xhochy commented Jan 11, 2021

Oh yes, definitely!

@xhochy
Copy link
Member Author

xhochy commented Jan 12, 2021

@github-actions crossbow submit -g wheel

@github-actions
Copy link

github-actions bot commented Jan 12, 2021

Revision: 4fe319c

Submitted crossbow builds: ursa-labs/crossbow @ actions-875

Task Status
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux1-cp39 Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2010-cp39 Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-manylinux2014-cp39 Azure
wheel-osx-high-sierra-cp36m Github Actions
wheel-osx-high-sierra-cp37m Github Actions
wheel-osx-high-sierra-cp38 Github Actions
wheel-osx-high-sierra-cp39 Github Actions
wheel-osx-mavericks-cp36m Github Actions
wheel-osx-mavericks-cp37m Github Actions
wheel-osx-mavericks-cp38 Github Actions
wheel-osx-mavericks-cp39 Github Actions
wheel-win-cp36m Github Actions
wheel-win-cp37m Github Actions
wheel-win-cp38 Github Actions

kszucs
kszucs reviewed Jan 12, 2021
View reviewed changes
python/requirements-wheel-test.txt
numpy==1.16.0; python_version == "3.7"
numpy==1.17.3; python_version == "3.8"
numpy==1.19.3; python_version >= "3.9"
numpy==1.19.4
Copy link
Member

@kszucs kszucs Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy shouldn't we test with 1.16.6 for python < 3.9 instead?

Copy link
Member Author

@xhochy xhochy Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test with the numpy release we have built with and a much newer one to detect issues. Currently we only test with one and there I would prefer to test with a newer release as this has a higher chance to fail on the C-API level like we have seen with the 1.20 release candidate.

Copy link
Member

@kszucs kszucs Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sounds good to me.

kszucs
kszucs approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@kszucs kszucs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging on green, and will handle the failing builds in #9096

@kszucs
Copy link
Member

kszucs commented Jan 12, 2021

The travis builds are still pending but it shouldn't affect them, so merging.

@kszucs kszucs closed this in 0c24bd7 Jan 12, 2021
@xhochy xhochy deleted the ARROW-10861 branch January 12, 2021 14:14
@asfimport asfimport mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@kszucs kszucs kszucs approved these changes

Assignees

No one assigned

Labels

Component: Python needs-rebase A PR that needs to be rebased by the author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xhochy @kou @pitrou @jorisvandenbossche @kszucs