Release 0.23.0 (please TEST!)

[Stypox]

Testing for regressions

Debug APK (built by our CI in #8231): NewPipe_0.23.0_RC2.zip
Release APK (signed with Stypox's keys): NewPipe_0.23.0_RC2.zip
Please report only regressions (i.e. new issues) here, not issues that were already present in the previous release!

TODO

• Merge Weblate
• Unlock Weblate when 0.23.0 is released
• Possibly including @TiA4f8R's extractor improvement to solve potential future throttling issues
  • In this case a new NewPipeExtractor version needs to be released,
  • and the extractor commit should be updated in the gradle dependencies.
• Possibly see if Slow initial video buffer #7630 can be solved in this release
  • Use 64 KiB as the default progressive load interval #8302
• Fix new streams notifications preference screen #8233
• Fix proguard for notification preference fragment #8236
• Fix crash when open NewPipe from notification bar #8244
• Fix disabled caption to no longer automatically re-enable on new player instance #8249
• DEFINITELY Adapt opacity of popup close button to allow touches in other apps on Android >=12 #8279

NewPipeExtractor version

This version of NewPipe will ship with NewPipeExtractor version 0.22.1

App changelog

New

• Add seamless transition between background and video players when putting the app in background (for video-only streams and audio-only streams only) Add seamless transition between background and video players when putting the app in background (for video-only streams and audio-only streams only) #7349 Fix fetch of video streams (when switching between tracks in a play queue) and subtitles when using a seamless transition between background and video players #8139
• Change pitch by semitones Change pitch by semitones #7565
• Implement appending queue to playlist in main player Implement appending queue to playlist in main player #8008
• New streams notifications New streams notifications #2335
• Load YouTube mixes in related items Add MixInfoItem and extract YouTube mixes in related items NewPipeExtractor#788 -- note that this has already been broken by YouTube

Improved

• Remember adjustment step size for playback controls (speed and pitch) Remember adjustment step size for playback controls (speed and pitch) #7728
• Mitigating long buffering on initial video playback Mitigating long buffering on initial video playback #7919
• Replace R.string.yes with R.string.ok Replace R.string.yes with R.string.ok #7976
• Improve player UI and navigability for Android TV Improve player UI and navigability for Android TV #7963
• Add a confirmation button when deleting all files in downloader Add a confirmation button when deleting all files in downloader #5878
• ExoPlayer 2.17.1 update and MediaSource management rework ExoPlayer 2.17.1 update and MediaSource management rework #8020 Fix caption auto-selection not reflected in player GUI #8150

Fixed

• Fix player controls not hiding if resumed from media button Fix player controls not hiding if resumed from media button #7341
• Migrate app update checker to AndroidX Work Migrate app update checker to AndroidX Work #7975
• Fix error notification on KitKat Fix error notification on KitKat #7977
• Fix playback being reset to beginning when player type was changed ExoPlayer 2.17.1 update and MediaSource management rework #8020
• Fix download dialog selector layout Fix download dialog selector layout #7516
• Fix crash when rotating device with playlist dialog open Use newInstance in PlaylistDialog #8146
• Adapt opacity of popup close button to allow touches in other apps on Android >=12 Adapt opacity of popup close button to allow touches in other apps on Android >=12 #8279

Development

• Replace CircleImageView with ShapeableImageView Replace CircleImageView with ShapeableImageView #7925
• Solve Java warning Raw use of parameterized class Solve Java warning "Raw use of parameterized class" #7904
• Fix Room warning about unused columns during build Fix Room warning about unused columns during build #7905
• Fix build on Apple Silicon Macs Fix build on Apple Silicon macs #7782
• Refactor generating InfoItemDialog's Refactor generating InfoItemDialog's #7570
• Better equals check Better equals check #7910
• Update Android Gradle Plugin and Gradle Update AGP and Gradle #7947
• Remove duplicate large-land player layout Remove large-land player layout: not actually used #7894
• Update ConstraintLayout and Room libraries Update ConstraintLayout, Room libraries #7954
• Update Kotlin to 1.6.10 Update Kotlin to 1.6.10 #7952
• Update some AndroidX libraries Update some AndroidX libraries #7978
• Remove icon duplicates and fix some theming issues Remove icon duplicates and fix some theming issues #7518 Remove pin and notifications night icons #8081
• Deduplicate code for fetching stream info when sparse Deduplicate code for fetching stream info when sparse #7981 Fix SparseItemUtil so we don't enqueue twice #8127
• Extract some view click listeners from player Extract view click listeners from Player #8011
• Delete some unused code Delete some unused code #8067
• Clean up the about package a bit Clean up the about package a bit #8065
• Create stub implementation for OnSeekBarChangeListener Create stub implementation for OnSeekBarChangeListener #8066
• Some lint cleaning Some lint cleaning #8068
• Update Checkstyle to 10.0 and fix various related issues Update checkstyle to 10.0 and fix various related issues #8073
• Update license to latest version Update license to latest version #8076 Delete copyright-file #8077
• Update CONTRIBUTING.md with current checkstyle.xml path Update CONTRIBUTING.md with current checkstyle.xml path #8175
• Updated extractor to latest version of the dev-branch Updated extractor to latest version of the dev-branch #8191
• Update GitHub action dependencies in workflows Update action dependencies in workflows #8198
• Update AGP, Gradle, and Kotlin Update AGP, Gradle, and Kotlin #8204
• Use simpler DrawerLayout method Use simpler DrawerLayout method #8200
• Replace checklist drawable Replace checklist drawable #8199

[Stypox]

@tsiflimagas reported this crash on IRC, it happens in the release build when tapping on Channels in the New stream notifications settings.
Edit: fixed by #8236

Crash log

Exception

• User Action: ui error
• Request: ACRA report
• Content Language: en-GB
• Service: none
• Version: 0.23.0
• OS: Linux Android 10 - 29

androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment org.schabi.newpipe.settings.notifications.NotificationModeConfigFragment: make sure class name exists
	at androidx.fragment.app.FragmentFactory.loadFragmentClass(FragmentFactory.java:97)
	at androidx.fragment.app.Fragment.instantiate(Fragment.java:611)
	at androidx.fragment.app.FragmentContainer.instantiate(FragmentContainer.java:57)
	at androidx.fragment.app.FragmentManager$3.instantiate(FragmentManager.java:483)
	at org.schabi.newpipe.settings.SettingsActivity.instantiateFragment(SettingsActivity.java:181)
	at org.schabi.newpipe.settings.SettingsActivity.onPreferenceStartFragment(SettingsActivity.java:174)
	at androidx.preference.PreferenceFragmentCompat.onPreferenceTreeClick(PreferenceFragmentCompat.java:422)
	at androidx.preference.Preference.performClick(Preference.java:1208)
	at androidx.preference.Preference.performClick(Preference.java:1182)
	at androidx.preference.Preference$1.onClick(Preference.java:182)
	at android.view.View.performClick(View.java:7259)
	at android.view.View.performClickInternal(View.java:7236)
	at android.view.View.access$3600(View.java:801)
	at android.view.View$PerformClick.run(View.java:27892)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7356)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:940)
Caused by: java.lang.ClassNotFoundException: org.schabi.newpipe.settings.notifications.NotificationModeConfigFragment
	at java.lang.Class.classForName(Native Method)
	at java.lang.Class.forName(Class.java:454)
	at androidx.fragment.app.FragmentFactory.loadClass(FragmentFactory.java:53)
	at androidx.fragment.app.FragmentFactory.loadFragmentClass(FragmentFactory.java:94)
	... 20 more
Caused by: java.lang.ClassNotFoundException: org.schabi.newpipe.settings.notifications.NotificationModeConfigFragment
	... 24 more

[litetex]

Possibly see if #7630 can be solved in this release

I think we have some kind of buffering problem which now affects all streams (until 0.23.0 it only affected YT 60fps streams). I created a new issue for that: #8238

[VaclavTrpisovsky]

I cannot import settings exported from 0.22.2 (this crashes 0.23.0 RC1 without a "Guru Meditation" screen appearing). Is this intended behavior to prevent some kind of "interference" between the official releases and Beta versions? (Sorry if this does not fit here. However, I do not believe this to be a regression as 0.22.2→0.22.2 import works. Feel free to ask for more information.)

Invalid, see below

[Stypox]

@VaclavTrpisovsky no, your comment is relevant. Could you share the crash report?

[VaclavTrpisovsky]

I am so sorry :( I accidentally chose the downloaded zipped APK instead of the exported settings, it's my fault. The behavior is the same in 0.22.2 (toast message Warning: Could not import all files and a split-second later restart when wrong ZIP is selected). I would welcome no restart and/or a more understandable message - but that does not belong in this thread as this is not a regression.

TLDR: My installation suffers from Stupid User Syndrome

[karyogamy]

Found another issue in #8150: After selecting No Caption before closing a player instance, open a new next player instance, and its track selector will automatically select a caption, even if caption is disabled as mentioned.

[SameenAhnaf]

2. When system dark mode is enabled, a lot of components lack contrast. This isn't the case when theme is changed from app settings.

Screen recording

Screenrecorder-2022-04-18-23-47-32-352.mp4

First bug is removed as it was reproducible in previous app versions

[peat80]

If one goes to settings > notifications and then click on channels the app always crashes.

Exception

• User Action: ui error
• Request: ACRA report
• Content Country: DE
• Content Language: de
• App Language: de
• Service: none
• Version: 0.23.0
• OS: Linux Android 10 - 29

Crash log

androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment org.schabi.newpipe.settings.notifications.NotificationModeConfigFragment: make sure class name exists
	at androidx.fragment.app.FragmentFactory.loadFragmentClass(FragmentFactory.java:97)
	at androidx.fragment.app.Fragment.instantiate(Fragment.java:611)
	at androidx.fragment.app.FragmentContainer.instantiate(FragmentContainer.java:57)
	at androidx.fragment.app.FragmentManager$3.instantiate(FragmentManager.java:483)
	at org.schabi.newpipe.settings.SettingsActivity.instantiateFragment(SettingsActivity.java:181)
	at org.schabi.newpipe.settings.SettingsActivity.onPreferenceStartFragment(SettingsActivity.java:174)
	at androidx.preference.PreferenceFragmentCompat.onPreferenceTreeClick(PreferenceFragmentCompat.java:422)
	at androidx.preference.Preference.performClick(Preference.java:1208)
	at androidx.preference.Preference.performClick(Preference.java:1182)
	at androidx.preference.Preference$1.onClick(Preference.java:182)
	at android.view.View.performClick(View.java:7192)
	at android.view.View.performClickInternal(View.java:7166)
	at android.view.View.access$3500(View.java:824)
	at android.view.View$PerformClick.run(View.java:27592)
	at android.os.Handler.handleCallback(Handler.java:888)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:213)
	at android.app.ActivityThread.main(ActivityThread.java:8178)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1101)
Caused by: java.lang.ClassNotFoundException: org.schabi.newpipe.settings.notifications.NotificationModeConfigFragment
	at java.lang.Class.classForName(Native Method)
	at java.lang.Class.forName(Class.java:454)
	at androidx.fragment.app.FragmentFactory.loadClass(FragmentFactory.java:53)
	at androidx.fragment.app.FragmentFactory.loadFragmentClass(FragmentFactory.java:94)
	... 20 more
Caused by: java.lang.ClassNotFoundException: org.schabi.newpipe.settings.notifications.NotificationModeConfigFragment
	... 24 more

---