Skip to content

Conversation

@SpinHit
Copy link
Contributor

@SpinHit SpinHit commented Mar 22, 2021

Adding an confirmation button while deleting all files.

Fixes the following issue(s)

@SpinHit
Copy link
Contributor Author

SpinHit commented Mar 22, 2021

Hello how can i add translation reference ?

@AudricV AudricV changed the title Add confirmation Button. Add a confirmation button when deleting all files in downloader Mar 23, 2021
@AudricV AudricV added downloader Issue is related to the downloader feature request Issue is related to a feature in the app labels Mar 23, 2021
@sonarqubecloud

This comment has been minimized.

@SpinHit SpinHit force-pushed the spinhit/addingDeleteConfirmation branch from 7cb1164 to 69d3c72 Compare March 29, 2021 15:34
@SpinHit
Copy link
Contributor Author

SpinHit commented Mar 29, 2021

Hi i rebased my work , is it good for you ?

@SpinHit
Copy link
Contributor Author

SpinHit commented Apr 15, 2021

Hi @Stypox and @TiA4f8R what do I have to do to make it merge?

@AudricV
Copy link
Member

AudricV commented Apr 15, 2021

Nothing for now, just wait until a member of the team review again your PR (I can't for now).

@darnuria
Copy link

@Stypox I sorry to disturb you, just a small follow-up from @SpinHit contribution, I mentored them in a project course where the goal we tutored students to make a first contribution.

Is their contribution ok? :)

Thanks for your time spent in reviewing this it was a great experience for them, if there is any problem get in touch with @SpinHit and I. :)

@Stypox Stypox force-pushed the spinhit/addingDeleteConfirmation branch from e4f55f2 to 483dc06 Compare March 2, 2022 10:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Stypox
Copy link
Member

Stypox commented Mar 2, 2022

I applied all of the pending suggestions and more:

  • Use "Ok" and "Cancel" instead of creating a new "No" string (and using the "Yes" string which should not be used, I will open a PR soon for removing it)
  • Reformat and refactor code
  • Use correct order of buttons

I tested on API 31 and API 19 and it worked as expected. This is such a small change, it can be merged right away @litetex

@Stypox Stypox mentioned this pull request Mar 2, 2022
5 tasks
@litetex litetex merged commit f47f2d1 into TeamNewPipe:dev Mar 15, 2022
@Stypox Stypox mentioned this pull request Apr 16, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

downloader Issue is related to the downloader feature request Issue is related to a feature in the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirmation before deleting all downloads

7 participants