-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add a confirmation button when deleting all files in downloader #5878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a confirmation button when deleting all files in downloader #5878
Conversation
|
Hello how can i add translation reference ? |
app/src/main/java/us/shandian/giga/ui/fragment/MissionsFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/us/shandian/giga/ui/fragment/MissionsFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/us/shandian/giga/ui/fragment/MissionsFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/us/shandian/giga/ui/fragment/MissionsFragment.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
7cb1164 to
69d3c72
Compare
|
Hi i rebased my work , is it good for you ? |
|
Hi @Stypox and @TiA4f8R what do I have to do to make it merge? |
|
Nothing for now, just wait until a member of the team review again your PR (I can't for now). |
|
@Stypox I sorry to disturb you, just a small follow-up from @SpinHit contribution, I mentored them in a project course where the goal we tutored students to make a first contribution. Is their contribution ok? :) Thanks for your time spent in reviewing this it was a great experience for them, if there is any problem get in touch with @SpinHit and I. :) |
app/src/main/java/us/shandian/giga/ui/fragment/MissionsFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/us/shandian/giga/ui/fragment/MissionsFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/us/shandian/giga/ui/fragment/MissionsFragment.java
Outdated
Show resolved
Hide resolved
Co-authored-by: TiA4f8R <[email protected]>
e4f55f2 to
483dc06
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
I applied all of the pending suggestions and more:
I tested on API 31 and API 19 and it worked as expected. This is such a small change, it can be merged right away @litetex |








Adding an confirmation button while deleting all files.
Fixes the following issue(s)