Skip to content

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@litetex litetex self-requested a review February 27, 2022 16:56
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; build works fine and the app works as expected

@TacoTheDank
The only thing I noticed was that the build now says:

> Task :app:formatKtlint
18:04:36.266 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "baseline" id.
18:04:36.268 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "checkstyle" id.
18:04:36.268 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "json" id.
18:04:36.268 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "html" id.
18:04:36.268 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "plain" id.
18:04:36.268 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "sarif" id.
18:04:36.268 [main] DEBUG com.pinterest.ktlint.Main - Initializing "plain" reporter with {verbose=false, color=false, color_name=DARK_GRAY}
18:04:38.244 [main] DEBUG com.pinterest.ktlint.Main - 2347ms / 82 file(s) / 0 error(s)

@TacoTheDank
Copy link
Member Author

TacoTheDank commented Feb 27, 2022

@litetex Yeah I got that too. I couldn't find anything related in the project, so it might be an internal ktlint thing.

@litetex litetex merged commit f1c6988 into TeamNewPipe:dev Feb 28, 2022
@TacoTheDank TacoTheDank deleted the bumpKotlin branch March 1, 2022 20:49
@Stypox Stypox mentioned this pull request Apr 16, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants