Skip to content

PR for https://github.com/Islandora/advanced_search/issues/68 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from

Conversation

kylehuynh205
Copy link
Contributor

What does this Pull Request do?

Provide a brief description of what the intended result of the PR will be and/or what
problem it solves.

  • Related GitHub Issue: (issues/68)

  • Other Relevant Links: (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

  • Wrap the constant text "Result per page", "Keyword" with Drupal's translation function call

How should this be tested?

A description of what steps someone could take to:

  • Have a site with multiple languages setup ie English and French or English and Tamil,
  • Setup Advanced Search view and blocks.
  • Implement Language switcher to switch between languages
  • Visit /admin/config/regional/translate, and search "Result Per page", "Keyword", any sort field label...., and input the translated values for them.
  • Clear Caches
  • Re-visit the search view and switch to targeted language

Documentation Status

  • Does this change existing behaviour that's currently documented?
  • Does this change require new pages or sections of documentation?
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

Fixed concatenating string '+' instead of '.'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant