Override global display mode settings for each Search Results Pager block #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override display mode config for SearchResultsPagerBlock different from global advanced search.
Add a hidden option for default display mode if both Grid and View mode is inactive
Updated the Ajax js to handle the case of the display mode is override in the SearchResultPagerBlock.php against the Global Advanced Search setting (only for initial load)
Added handling display mode override from block instead global for ajax events
Fix a small bug, get the display mode text from type attribute instead of the tag's text, because it may got translated so it's not matched with 'list' or 'grid'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Provide a brief description of what the intended result of the PR will be and/or what
problem it solves.
Related GitHub Issue: (issue #72)
Other Relevant Links: (Google Groups discussion, related pull requests,
Release pull requests, etc.)
What's new?
A in-depth description of the changes made by this PR. Technical details and
possible side effects.
This PR add additional settings for display mode at Search Results Pager Block (screenshot below), this will override global settings
/admin/config/search/advanced:How should this be tested?
In global settings at
/admin/config/search/advanced, set display mode asIn an advanced search view, configure the Pager block ie https://sandbox.islandora.ca/admin/structure/block/manage/solrsearchcontentsearchresultspagerforblock, set something like this:
then, go back to Search view, ie. https://sandbox.islandora.ca/islandora/book-collection, expect there is no display mode options display and the default display is grid instead of list.
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers