Validation outputs #56
Conversation
feature layer instead to get the affine info
|
I have some more testing to do, will re-open when done. |
the collagborators (as by the time we get the val scores, the aggregator has replaced aggregator.last_tensor_dict
|
Ok re-opening, with the reminder that this is dependent on an openfl pull request(#114) |
|
I think this is good to merge, what do you think, @psfoley? |
Task_1/FeTS_Challenge.ipynb
Outdated
| "data_path = '/raid/edwardsb/validation_set'\n", | ||
| "\n", | ||
| "# you can keep these the same if you wish\n", | ||
| "best_model_path = '/home/edwardsb/.local/workspace/checkpoint/' + checkpoint_folder + '/best_model.pkl'\n", |
There was a problem hiding this comment.
For these paths, it might be worth doing something like this so the user doesn't need to modify their home directory:
from pathlib import Path
home = str(Path.home())
best_model_path = f'{home}/.local/workspace/checkpoint/{checkpoint_folder}/best_model.pkl'
outputs_path = f'{home}/.local/workspace/checkpoint/{checkpoint_folder}/model_outputs'
There was a problem hiding this comment.
Good catch Patrick, thanks. I missed that this was in the part I was suggesting did not need to be changed as well.
Task_1/FeTS_Challenge.ipynb
Outdated
| "# you will need to specify the correct experiment folder and the parent directory for\n", | ||
| "# the data you want to run inference over\n", | ||
| "checkpoint_folder='experiment_1'\n", | ||
| "data_path = '/raid/edwardsb/validation_set'\n", |
There was a problem hiding this comment.
Maybe make this clear that this is the validation data downloaded from the challenge? i.e.
data_path = /PATH/TO/CHALLENGE_VALIDATION_DATA
|
I just have two small comments related to replacing hard coded paths. Beyond that, this is ready to merge 👍 |
brandon-edwards
left a comment
brandon-edwards
left a comment
There was a problem hiding this comment.
Made the changes Patrick suggested and did another run test.
3 participants
No description provided.