Skip to content

Conversation

@psfoley
Copy link
Collaborator

@psfoley psfoley commented Jul 22, 2021

This PR closes #97

setup.py needs to be updated with the right FeTS Algorithms commit ID before this can be merged

@psfoley psfoley requested a review from sarthakpati July 22, 2021 00:04
Copy link
Member

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@psfoley psfoley changed the title WIP: Make results reproducible Make results reproducible Jul 22, 2021
@psfoley
Copy link
Collaborator Author

psfoley commented Jul 22, 2021

@sarthakpati I just removed the WIP tag. Were you able to test this with an Nvidia GPU? Should be ready to merge after that. Thanks!

@sarthakpati
Copy link
Member

Yup, it worked for me on 3 different GPUs (P100, V100 and RTX 3090). Going ahead with merge.

@sarthakpati sarthakpati merged commit 8ce5c93 into main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding manual seed for reproducibility

3 participants