Tools: Additional fix for ubuntu prereq script $PATH whitespace bug #30704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avenstewart
force-pushed
the
prereq-install-ubuntu-fix
branch
from
3876afc to
6070db4
Compare
amilcarlucas
approved these changes
Jul 21, 2025
avenstewart
force-pushed
the
prereq-install-ubuntu-fix
branch
from
9e7f6bf to
2375560
Compare
peterbarker
reviewed
Jul 21, 2025
| else | ||
| echo "Skipping adding $OPT/$ARM_ROOT/bin to PATH." | ||
| fi | ||
| } | ||
| fi | ||
|
|
||
| exportline2="export PATH=$ARDUPILOT_ROOT/$ARDUPILOT_TOOLS:\$PATH"; | ||
| exportline2="export \"PATH=$ARDUPILOT_ROOT/$ARDUPILOT_TOOLS:\$PATH\""; |
There was a problem hiding this comment.
Does this work correctly?
Shouldn't this be
Suggested change
| exportline2="export \"PATH=$ARDUPILOT_ROOT/$ARDUPILOT_TOOLS:\$PATH\""; | |
| exportline2="export PATH=\"$ARDUPILOT_ROOT/$ARDUPILOT_TOOLS:\$PATH\""; |
?
Similarly on other lines in here
There was a problem hiding this comment.
Yes, i've tested it extensively. Linter throws a warning about backslashes, but there was no cleaner solution I could find.
There was a problem hiding this comment.
Updated with your suggestion
peterbarker
force-pushed
the
prereq-install-ubuntu-fix
branch
from
3d4f700 to
7158045
Compare
peterbarker
approved these changes
Jul 28, 2025
|
Merged, thanks! .... but I do suggest you avoid spaces in your paths anyway :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for initial fix #30582 for bug #30477. Initial fix partially handled whitespace except during optional tool installs, wherein bug would still cause malformed $PATH to break Ubuntu PAM login.