Skip to content

Tools: Fix for failing preq ubuntu script due to whitespace in directory #30582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Tools: Fix for failing preq ubuntu script due to whitespace in directory #30582

merged 1 commit into from
Jul 9, 2025

Conversation

The13bit
Copy link
Contributor

@The13bit The13bit commented Jul 7, 2025

Fixes issue #30477

- SCRIPT_DIR=$(dirname $(realpath ${BASH_SOURCE[0]}))
+ SCRIPT_DIR="$(dirname "$(realpath "${BASH_SOURCE[0]}")")"

@peterbarker
Copy link
Contributor

Fixes issue #30477

Did you test this fix? It looks like it could work, but I do need to know it was tested :-)

@The13bit
Copy link
Contributor Author

The13bit commented Jul 8, 2025

yes here is the output of the script
image

@peterbarker peterbarker merged commit 867da3e into ArduPilot:master Jul 9, 2025
16 checks passed
@peterbarker
Copy link
Contributor

Merged, thanks!

I would suggest avoiding spaces in directory names, however. It's only going to cause you pain :-)

@avenstewart avenstewart mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@The13bit @peterbarker