Fix IOMCU transmission errors resulting from DMA timer interference #27201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
changed the title
|
@andyp1per what is the consequences of this bug? I assume it affects 4.5 as well? |
It affects 4.5 as well. Only happens with bdshot on channels 3/4. Consequences are dropped packets on the IOMCU uart because you get missing bytes at the beginning of frames. Its also somewhat timing dependent, if you build with assertions the problem goes away, if you put in a little sleep the problem goes away, it doesn't happen every frame - only now and then - hence why you were able to fly without issue. |
tridge
approved these changes
Jun 2, 2024
|
I've confirmed this bug impacts 4.5.x as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #27171
We basically needed to reset the PWM peripheral when releasing the IC DMA lock in the same way we do for the main DMA channel.