fix various typos #237
Open
fix various typos #237
+606
−337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazydef
reviewed
Jul 30, 2025
| @@ -11,7 +11,7 @@ var hambagas = [ | |||
| "https://www.youtube.com/watch?v=pFA3KGp4GuU" | |||
| ]; | |||
|
|
|||
| // keybaord, | |||
| // keyboard, | |||
| // onscreen keyboard by @steinuil | |||
| function initKeybaord(BASE_URL, HAMBAGA, consoleLog, consoleError) { | |||
There was a problem hiding this comment.
initKeybaord should be renamed to initKeyboard.
There was a problem hiding this comment.
Do you prefer for me to make source changes in this PR or a separate one ?
Edit:
crazydef
reviewed
Jul 30, 2025
| @@ -373,7 +373,7 @@ function initKeybaord(BASE_URL, HAMBAGA, consoleLog, consoleError) { | |||
| } | |||
|
|
|||
|
|
|||
| // keybaord integration | |||
| // keyboard integration | |||
| (function () { | |||
| var o = mknod('div'); | |||
| clmod(o, 'keybaord-container', 1); | |||
|
Found a typo while reviewing the Spanish translation PR copyparty/copyparty/web/browser.js Line 327 in c3cc2dd |
The version attribute is deprecated, resolves error "the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion" when building with Docker Signed-off-by: ptweezy <[email protected]>
Comic readers will sort alphabetically, but that isn't always the order in which the files are stored in the zip.
* add feature showcase video Signed-off-by: Adam <[email protected]> * add youtube link too Signed-off-by: ed <[email protected]> --------- Signed-off-by: Adam <[email protected]> Signed-off-by: ed <[email protected]> Co-authored-by: ed <[email protected]>
* nix: allow passing extra packages in PATH * nix: allow passing extra python packages I wanted to use https://github.com/9001/copyparty/blob/hovudstraum/bin/hooks/notify.py but that wasn't really possible without this under the nix package. * nix: format all nix files with nixfmt * nix: reduce redundancy in the package For readability * nix: remove unused pyftpdlib import * nix: put makeWrapper into the correct inputs * nix: fill out all of meta * nix: set formatter in flake for nix files This allows contributors to format their nix changes with the `nix fmt` command. * nix: add u2c * nix: add partyfuse One downside of the way the nix ecosystem works is that MacFUSE needs to be installed manually. Luckily the script tells you that already! * nix: add missing cfssl import * nix: add flake check that makes sure it builds with all flags Because sometimes an import might be missing, and if it is an optional then you'll only figure out that it's broken if you set the flag. * nix: use correct overlay argument names Or `nix flake check` will refuse to run the copyparty-full check
almost zero performance impact with podman in kitty
Signed-off-by: Jo <[email protected]>
also makes rejections from IdP auths less confusing; it was handled by the config-parser throwing "invalid config"
Found via `codespell -q 3 -L ascript,caf,clen,fo,nd,oen,pres,som,te,tread,warks -S "*.patch"` This PR complies with the DCO; https://developercertificate.org/
|
Crap. Thought i rebased it on the correct branch ? The relevant commits are the last 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via
codespell -q 3 -L ascript,caf,clen,fo,nd,oen,pres,som,te,tread,warks -S "*.patch"This PR complies with the DCO; https://developercertificate.org/