various improvements to the nix files #228
Conversation
I wanted to use https://github.com/9001/copyparty/blob/hovudstraum/bin/hooks/notify.py but that wasn't really possible without this under the nix package.
For readability
This allows contributors to format their nix changes with the `nix fmt` command.
One downside of the way the nix ecosystem works is that MacFUSE needs to be installed manually. Luckily the script tells you that already!
Because sometimes an import might be missing, and if it is an optional then you'll only figure out that it's broken if you set the flag.
Or `nix flake check` will refuse to run the copyparty-full check
|
It's good to have an actual nixpkgs contributor look through these. All changes seem like an improvement to me without breaking anything, so it should be safe to merge this @9001. It seems like everyone who touched nix in this repo chose to use a different formatter, but since you've included yours in the flake, I'd say we have a winner. |
|
sweet, was waiting for you to get a chance to peep it :> thanks a lot for the contribution! |
Yeah. It was kinda the wild west for a while. But |
|
Thanks for merging! Now I can use hooks with additional dependencies as well! Okay, so what I'm still interested in:
|
It looks like someone beat you to it, but maybe you are interested in collaborating there, in case you find it insufficiently good. Strictly speaking that's not a real "built from source" derivation, but it may be a reasonable compromise. Some web dependencies such as |
Yeah, I saw. Very nice! The PR looks fine. I understand it's not entirely "pure" but it's better than "yeah let's just grab the sfx and call it a day" There are a couple packages that are pulled in the dockerfile that could be replaced with preexisting nixpkgs packages or custom derivations, but there's not a lot of juice to squeeze there. I think there's a much simpler way to improve reproducibility for the web deps and it's ADD --checksum in the dockerfile. That doesn't require |
* nix: allow passing extra packages in PATH * nix: allow passing extra python packages I wanted to use https://github.com/9001/copyparty/blob/hovudstraum/bin/hooks/notify.py but that wasn't really possible without this under the nix package. * nix: format all nix files with nixfmt * nix: reduce redundancy in the package For readability * nix: remove unused pyftpdlib import * nix: put makeWrapper into the correct inputs * nix: fill out all of meta * nix: set formatter in flake for nix files This allows contributors to format their nix changes with the `nix fmt` command. * nix: add u2c * nix: add partyfuse One downside of the way the nix ecosystem works is that MacFUSE needs to be installed manually. Luckily the script tells you that already! * nix: add missing cfssl import * nix: add flake check that makes sure it builds with all flags Because sometimes an import might be missing, and if it is an optional then you'll only figure out that it's broken if you set the flag. * nix: use correct overlay argument names Or `nix flake check` will refuse to run the copyparty-full check
This PR complies with the DCO; https://developercertificate.org/
Summary:
I haven't looked at the NixOS module as much, but I think I'll make some improvements to that one later.