City state resources

[MorphicDreamer]

This is basically my old pull request but better!

[SomeTroglodyte]

Just remember you got nudged in that direction from someone who managed to overdo their Kdoc's. Also - there's tricks and quirks. Maybe I kept records of some stuff I learned in my notes, or maybe I forgot.

[MorphicDreamer]

@SomeTroglodyte

I made the function more generic and moved the more specific stuff to the declaration of the list.

Thanks for the feedback.

[SomeTroglodyte]

<facepalm/> That Civ5 screenshot that could show Yair this feature was indeed in Civ5 - I searched in vain in issues - and it's of course in the predecessor PR, and of course thanks to ravignir:
#4752 (comment)

[SomeTroglodyte]

Forgot one nitpick: isn't .map {it} a no-op? As always, just food for thought.

[MorphicDreamer]

@yairm210 gotcha will fix tomorrow morning

[MorphicDreamer]

not sure how to use templates though

[yairm210]

For the translation, we need

Build [improvementName] on [resourceName] (200 Gold) =
Gift Improvement =

to be added to the template.properties file

[ajustsomebody]

For the translation, we need

Build [improvementName] on [resourceName] (200 Gold) =
Gift Improvement =

to be added to the template.properties file

what about just adding [amount] Gold?

[MorphicDreamer]

@yairm210 i did it

[yairm210]

looks good!
You have conflicts, resolve those and we'll merge :)

[MorphicDreamer]

yep fixed the conflicts. Ready to merge. :)

[yairm210]

The tests show that your translation lines don't end with a space
Add and the tests should pass :)

[MorphicDreamer]

Fixed!

[SomeTroglodyte]

Congrats on your second merged PR!

The short discussion on template.properties has prompted me to add an extra chapter to the wiki entry on translations - please tell me if I explained badly or where I missed a detail.

[MorphicDreamer]

@SomeTroglodyte Thanks! The documentation looks good