Skip to content

You Can Now Gift 200 Gold To CIty States To Instantly Improve Their Resource #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 60 commits into from
Closed

Conversation

MorphicDreamer
Copy link
Contributor

You can now gift 200 gold to city states to instantly improve their resource according to the specification provided by logicminimal #4602

The gold goes directly from the offering civ to city state

The tile tech required is based of the city states and not the offering civ.

@ajustsomebody
Copy link
Contributor

@logicminimal yeah I can't code that. lol

unfortunate, hope someone else does in the future, can you atleast give a distinction if there are more than 1 of an improvement-able tile?

# Conflicts:
#	core/src/com/unciv/logic/city/CityInfo.kt
#	core/src/com/unciv/ui/trade/DiplomacyScreen.kt
@MorphicDreamer
Copy link
Contributor Author

@logicminimal it will show multiple improvements if there are more than 1 of an improvable tile

@ajustsomebody
Copy link
Contributor

@logicminimal it will show multiple improvements if there are more than 1 of an improvable tile

how is there a distinction between them though, what about if you press them they would change the camera's position to that tile just like it does with city centers when a new resource gets discovered near city?

@MorphicDreamer
Copy link
Contributor Author

Sorry for all of the unnecessary commits. I finished the commit then while trying to clean the mess up, ended up accidentally deleting all off the work I did.

@MorphicDreamer
Copy link
Contributor Author

@logicminimal the distinction doesn't matter. A Pasture is a Pasture

@ajustsomebody
Copy link
Contributor

@logicminimal the distinction doesn't matter. A Pasture is a Pasture

it does actually a bit strategically, and the buttons taking you to where thr tile is would be a great quality of life touch

@MorphicDreamer
Copy link
Contributor Author

Now only Strategic and Luxury resources can be improved with improvements that harvest the resource

@MorphicDreamer
Copy link
Contributor Author

@logicminimal I think that can be implemented, but it would look clunky and disconnected from the rest of the game. Maybe later

@MorphicDreamer MorphicDreamer marked this pull request as ready for review August 4, 2021 08:43
@MorphicDreamer
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants