Skip to content

Ruby 2.4 Support #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2017
Merged

Ruby 2.4 Support #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a5383a
Test against 2.4 and not 2.1
packrat386 Apr 3, 2017
ddc641a
Use Numeric instead of Fixnum
packrat386 Apr 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
language: ruby
rvm:
- 2.1
- 2.2
- 2.3
- 2.4.1
- jruby
- rbx-2

Expand Down
2 changes: 1 addition & 1 deletion lib/rspec/sidekiq/matchers/be_retryable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def initialize(expected_retry)
end

def description
if @expected_retry.is_a?(Fixnum)
if @expected_retry.is_a?(Numeric)
"retry #{@expected_retry} times" # retry: 5
elsif @expected_retry
'retry the default number of times' # retry: true
Expand Down
2 changes: 1 addition & 1 deletion lib/rspec/sidekiq/matchers/save_backtrace.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def initialize(expected_backtrace=true)
end

def description
if @expected_backtrace.is_a?(Fixnum)
if @expected_backtrace.is_a?(Numeric)
"save #{@expected_backtrace} lines of error backtrace" # backtrace: 5
elsif @expected_backtrace
'save error backtrace' # backtrace: true
Expand Down