Skip to content

Ruby 2.4 Support #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2017
Merged

Ruby 2.4 Support #119

merged 2 commits into from
Jun 7, 2017

Conversation

packrat386
Copy link
Contributor

Changes to support ruby 2.4

  • Test against 2.4 and not 2.1
  • Use Numeric instead of Fixnum

@packrat386
Test against 2.4 and not 2.1
8a5383a 
Ruby 2.4 is out in force now, and 2.1 conveniently got end-of-lifed on
3/31/2017.
@packrat386
Use Numeric instead of Fixnum
ddc641a 
This will correctly include Integers in ruby 2.4 as per discussion on
PR wspurgin#117. Thanks to jsmestad.
@coveralls
Copy link

coveralls commented Apr 3, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 97.222% when pulling ddc641a on packrat386:ruby_24 into e5ede7a on philostler:develop.

@packrat386 packrat386 mentioned this pull request Apr 3, 2017
Closed
@jsmestad
Copy link

jsmestad commented Apr 3, 2017

@packrat386 looks good

@packrat386
Copy link
Contributor Author

@wpolicarpo can you take a look and merge this if it looks good?

@nelantone nelantone mentioned this pull request Apr 3, 2017
Closed
mathieujobin
mathieujobin approved these changes Apr 4, 2017
View reviewed changes
Copy link

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if i would drop support for 2.1 this early, probably should wait until we hit an incompatibility or a known bug we don't want to fix. otherwise 👍

@PikachuEXE
Copy link

I wonder why Numeric instead of Integer is used as Fixnum replacement
But I guess it's non-critical

@asurin
Copy link

asurin commented May 18, 2017

Any update here? This would be super userful

@packrat386 packrat386 merged commit e306247 into wspurgin:develop Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mathieujobin mathieujobin mathieujobin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@packrat386 @coveralls @jsmestad @PikachuEXE @asurin @mathieujobin