backend-notification-pusher: Dynamically discover remote domains #3366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
This allows tests to succeed in a sane amount of time
Remove unused deps
akshaymankar
force-pushed
the
dynamic-queues
branch
from
4d83eb9 to
ce432cd
Compare
battermann
approved these changes
Jun 27, 2023
Comment on lines
+50
to
+51
| rabbitmqAdminClient = undefined | ||
| rabbitmqVHost = undefined |
There was a problem hiding this comment.
I guess undefined is fine here?
There was a problem hiding this comment.
Yeah, I am trying to write tests without polysemy, I think this is the easiest thing we can do.
Comment on lines
+165
to
+166
| let federatorInternal = undefined | ||
| http2Manager = undefined |
There was a problem hiding this comment.
I guess this is fine, too?
elland
approved these changes
Jun 27, 2023
Too complicated to implment, will not realy be used in near future.
akshaymankar
commented
Jun 28, 2023
services/background-worker/src/Wire/BackendNotificationPusher.hs
Outdated
Show resolved
Hide resolved
services/background-worker/test/Test/Wire/BackendNotificationPusherSpec.hs
Outdated
Show resolved
Hide resolved
elland
pushed a commit
that referenced
this pull request
Jun 29, 2023
elland
added a commit
that referenced
this pull request
Jul 13, 2023
* Migrated notifications. * Undo EmptyResponse changes * Revert unnecessary test changes. * Revert mls welcome. * Added e2e test removing temp client across backends * Add integration test for client deletion * Removed redundant e2e * Updated nix for integration * Migrate on-msg-sent to queue * delete/adjust tests. * backend-notification-pusher: Dynamically discover remote domains (#3366) * Bumped timeout * Persist typing indicator * Reverted typing indicator back to sync RPC * Deleted outdated tests * [WPB-2789] Use EmptyResponse consistently across Galley federation endpoints (#3365) * Use EmptyResponse consistently for galley fed calls * Amended doc for empty response. * Fixed some failing tests. * Temporary remove test. * Restore EmptyResponse instead of (). * Restore tests removed by accident --------- Co-authored-by: Akshay Mankar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-1130
Checklist
changelog.d