Skip to content

[WPB-2789] Use EmptyResponse consistently across Galley federation endpoints #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2023
Merged

[WPB-2789] Use EmptyResponse consistently across Galley federation endpoints #3365

merged 3 commits into from
Jul 11, 2023

Conversation

elland
Copy link
Contributor

@elland elland commented Jun 19, 2023

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 19, 2023
@elland elland force-pushed the WPB-200-Move-all-notifications-to-RabbitMQ branch 4 times, most recently from 57f57ce to 2e18046 Compare June 20, 2023 11:55
@elland elland changed the title WIP: removed EmptyResponse [chore] Use EmptyResponse consistently across Galley federation endpoints Jun 21, 2023
@elland elland marked this pull request as ready for review June 21, 2023 09:30
@elland elland changed the title [chore] Use EmptyResponse consistently across Galley federation endpoints [WPB-2789] Use EmptyResponse consistently across Galley federation endpoints Jun 21, 2023
fisx
fisx approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there may also be some "NoContent" cases that you want to change, but i suppose that's not a breaking change, so doesn't have to happen here & now.

fisx
fisx reviewed Jun 21, 2023
View reviewed changes
@elland elland force-pushed the WPB-200-Move-all-notifications-to-RabbitMQ branch from 815b868 to 9c5ebd9 Compare June 29, 2023 07:49
@elland elland deleted the branch WPB-200-Move-all-notifications-to-RabbitMQ June 29, 2023 11:22
@elland elland closed this Jun 29, 2023
@elland elland reopened this Jul 10, 2023
@elland elland merged commit c28a592 into WPB-200-Move-all-notifications-to-RabbitMQ Jul 11, 2023
@elland elland deleted the empty-response branch July 11, 2023 14:05
elland added a commit that referenced this pull request Jul 13, 2023
@elland @akshaymankar
[WPB-200] Move all notifications to RabbitMQ (#3336)
3388bf0 
* Migrated notifications.

* Undo EmptyResponse changes

* Revert unnecessary test changes.

* Revert mls welcome.

* Added e2e test removing temp client across backends

* Add integration test for client deletion

* Removed redundant e2e

* Updated nix for integration

* Migrate on-msg-sent to queue

* delete/adjust tests.

* backend-notification-pusher: Dynamically discover remote domains (#3366)

* Bumped timeout

* Persist typing indicator

* Reverted typing indicator back to sync RPC

* Deleted outdated tests

* [WPB-2789] Use EmptyResponse consistently across Galley federation endpoints (#3365)

* Use EmptyResponse consistently for galley fed calls

* Amended doc for empty response.

* Fixed some failing tests.

* Temporary remove test.

* Restore EmptyResponse instead of ().

* Restore tests removed by accident

---------

Co-authored-by: Akshay Mankar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elland @fisx @zebot