docs: add documentation of client id to zauth readme #2967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
|
I realized, this is wrong, will update soon |
|
@pcapriotti @mdimjasevic now I'm more confident, that this reflects reality, ready for review |
mdimjasevic
reviewed
Jan 10, 2023
| @@ -7,10 +7,10 @@ version ::= "v=" Integer | |||
| key-index ::= "k=" Integer (> 0) | |||
| timestamp ::= "d=" Integer (POSIX timestamp, expiration time) | |||
| type ::= "t=" ("a" | "u" | "b" | "p") ; access, user, bot, provider | |||
| tag ::= "l=" ("s" | "" (session or nothing)) | |||
| tag ::= "l=" ("s" | "") ; session or nothing | |||
There was a problem hiding this comment.
I'm not too familiar with this syntax; what does ";" represent?
There was a problem hiding this comment.
Some languages use ; to indicate the a start of a comment.
I assumed it was used this way in the line 9, so so I tried to make it more consistent, because the parenthesis in line 10 seemed wrong to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification in the readme is missing the newly added (#2764) client-id part.
This PR intends to complete the specification.
Checklist
changelog.d