Skip to content

Add client ID to tokens #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 31, 2022
Merged

Add client ID to tokens #2764

merged 17 commits into from
Oct 31, 2022

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Oct 12, 2022 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti temporarily deployed to cachix October 12, 2022 13:13 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 12, 2022 13:13 Inactive
@pcapriotti pcapriotti changed the base branch from develop to pcapriotti/servantify-auth October 12, 2022 13:13
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 12, 2022
@smatting smatting temporarily deployed to cachix October 12, 2022 15:31 Inactive
@smatting smatting temporarily deployed to cachix October 12, 2022 15:31 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 13, 2022 09:08 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 13, 2022 09:08 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 13, 2022 09:34 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 13, 2022 09:34 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 13, 2022 11:05 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 13, 2022 11:05 Inactive
@pcapriotti pcapriotti force-pushed the pcapriotti/token-client-id branch from 6625484 to db5394d Compare October 13, 2022 13:13
@pcapriotti pcapriotti temporarily deployed to cachix October 13, 2022 13:13 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 13, 2022 13:13 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 17, 2022 13:34 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 17, 2022 13:34 Inactive
@pcapriotti pcapriotti force-pushed the pcapriotti/servantify-auth branch 2 times, most recently from 6670373 to d218c43 Compare October 20, 2022 12:21
@pcapriotti pcapriotti force-pushed the pcapriotti/token-client-id branch from 1bc4159 to fa05655 Compare October 20, 2022 12:23
@pcapriotti pcapriotti temporarily deployed to cachix October 20, 2022 12:23 Inactive
@pcapriotti pcapriotti force-pushed the pcapriotti/token-client-id branch from fa05655 to 75801aa Compare October 21, 2022 08:21
@pcapriotti pcapriotti temporarily deployed to cachix October 21, 2022 08:21 Inactive
@pcapriotti pcapriotti force-pushed the pcapriotti/token-client-id branch from 75801aa to 7d49096 Compare October 21, 2022 13:46
@pcapriotti pcapriotti temporarily deployed to cachix October 21, 2022 13:46 Inactive
Base automatically changed from pcapriotti/servantify-auth to develop October 24, 2022 08:43
@pcapriotti pcapriotti force-pushed the pcapriotti/token-client-id branch from 7d49096 to 1d28698 Compare October 24, 2022 08:53
@pcapriotti pcapriotti temporarily deployed to cachix October 24, 2022 08:53 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 24, 2022 12:22 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 24, 2022 12:49 Inactive
@pcapriotti pcapriotti marked this pull request as ready for review October 25, 2022 12:17
@pcapriotti pcapriotti temporarily deployed to cachix October 25, 2022 13:30 Inactive
mdimjasevic
mdimjasevic approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice improvement!

One part I wasn't sure of is your flattening of one function that you sprinkled with MaybeTs, but I believe you got it right.

@pcapriotti pcapriotti force-pushed the pcapriotti/token-client-id branch from bd07503 to e38fc86 Compare October 26, 2022 14:52
@pcapriotti pcapriotti temporarily deployed to cachix October 28, 2022 09:15 Inactive
@pcapriotti pcapriotti force-pushed the pcapriotti/token-client-id branch from f6d3e67 to d73480a Compare October 28, 2022 11:46
@pcapriotti pcapriotti temporarily deployed to cachix October 28, 2022 11:46 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix October 28, 2022 12:25 Inactive
@pcapriotti pcapriotti merged commit d733327 into develop Oct 31, 2022
@pcapriotti pcapriotti deleted the pcapriotti/token-client-id branch October 31, 2022 08:23
This was referenced Nov 2, 2022
Closed
Merged
@comawill comawill mentioned this pull request Jan 9, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcapriotti @mdimjasevic @smatting @zebot