Skip to content

Polysemy concurrency effect #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 5, 2022
Merged

Polysemy concurrency effect #2748

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
27b8a35
feat: add unsafe concurrency effect
isovector Oct 4, 2022
e84a5c1
feat: just hoist traverse
isovector Oct 4, 2022
5e06ffe
chore: make format
isovector Oct 4, 2022
fdda504
feat: add a "safety" flag
isovector Oct 4, 2022
dc6ab13
chore: make format
isovector Oct 4, 2022
33d2c2d
refactor: UnsafeConcurrency -> Concurrency
isovector Oct 4, 2022
1d15796
chore: make format
isovector Oct 4, 2022
b752a10
feat: add haddocks
isovector Oct 4, 2022
4dfdd6b
doc: changelog
isovector Oct 4, 2022
41afdc4
Hi CI
mdimjasevic Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions libs/polysemy-wire-zoo/src/Wire/Sem/Concurrency/IO.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,20 @@ import Polysemy.Final
import UnliftIO (pooledMapConcurrentlyN, pooledMapConcurrentlyN_)
import Wire.Sem.Concurrency (Concurrency (..), ConcurrencySafety (Safe))

------------------------------------------------------------------------------

-- | Safely perform concurrency that wraps only IO effects.
performConcurrency ::
Member (Final IO) r =>
Sem (Concurrency 'Safe ': r) a ->
Sem r a
performConcurrency = unsafelyPerformConcurrency

------------------------------------------------------------------------------

-- | VERY UNSAFELY perform concurrency in Polysemy. This is likely to lead to
-- obscure bugs. See the notes on 'Concurrency' to get a better understanding
-- of what can go wrong here.
unsafelyPerformConcurrency ::
Member (Final IO) r =>
Sem (Concurrency safe ': r) a ->
Expand Down
3 changes: 3 additions & 0 deletions libs/polysemy-wire-zoo/src/Wire/Sem/Concurrency/Sequential.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ import Imports
import Polysemy
import Wire.Sem.Concurrency

------------------------------------------------------------------------------

-- | Safely perform "concurrency" by doing it sequentially.
sequentiallyPerformConcurrency :: Sem (Concurrency safe ': r) a -> Sem r a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have been 'Safe instead of safe in the type :: Sem (Concurrency safe ': r) a -> Sem r a?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isovector , I guess this has slipped your attention because I merged this before you got a chance to reply. Here's just a reminder.

sequentiallyPerformConcurrency = interpretH $ \case
UnsafePooledMapConcurrentlyN _ f t -> do
Expand Down