Polysemy concurrency effect #2748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdimjasevic
approved these changes
Oct 5, 2022
| @@ -4,6 +4,9 @@ import Imports | |||
| import Polysemy | |||
| import Wire.Sem.Concurrency | |||
|
|
|||
| ------------------------------------------------------------------------------ | |||
|
|
|||
| -- | Safely perform "concurrency" by doing it sequentially. | |||
| sequentiallyPerformConcurrency :: Sem (Concurrency safe ': r) a -> Sem r a | |||
There was a problem hiding this comment.
Should this have been 'Safe instead of safe in the type :: Sem (Concurrency safe ': r) a -> Sem r a?
There was a problem hiding this comment.
@isovector , I guess this has slipped your attention because I merged this before you got a chance to reply. Here's just a reminder.
mdimjasevic
added
the
ok-to-test
|
@isovector , I just pushed an empty commit to your fork/branch to trigger our CI that otherwise has a hard time figuring out it should run. I hope this is fine by you. Otherwise I can copy your branch into |
|
@mdimjasevic thanks for being on top of it! |
This was referenced Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Concurrencyeffect topolysemy-wire-zoo, which lifts behavior fromunliftiofor splitting up tasks over multiple threads. In general, this is unsafe in application code and polysemy doesn't handle it very well, and in most cases it is going to create surprising bugs if it's used in application code.That being said, there are "safe" usages of
Concurrencywhere the only actions being lifted areIO, which is something interpreters can guarantee. TheConcurrencyeffect tracks enforces this safety constraint at the type level.Checklist
changelog.d