Added linting scripts. #2663
Merged
Added linting scripts. #2663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
stephen-smith
approved these changes
Aug 31, 2022
akshaymankar
reviewed
Sep 1, 2022
stephen-smith
approved these changes
Sep 1, 2022
fisx
reviewed
Sep 1, 2022
fisx
approved these changes
Sep 1, 2022
Co-authored-by: fisx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As our next step, I've added entries to the makefile to allow for quick linting changes as you work. Next step would be to add this to either git hooks and or CI.
Also updated some file changes to be linted and updated rules to remove some annoyances.
Regarding checkpoint 3 below, is there anything I should document about it?
Checklist