Added linting scripts. (#2663)

Author: elland

.hlint.yaml

@@ -8,8 +8,10 @@
 # Left for the programmer to decide. See discussion at https://github.com/wireapp/wire-server/pull/2382#discussion_r871194424
 - ignore: { name: Avoid lambda }
 - ignore: { name: Avoid lambda using `infix` }
-
+- ignore: { name: Eta reduce }
 - ignore: { name: Use section }
+- ignore: { name: Use underscore }
+
 # custom rules:
 - hint: { lhs: (() <$), rhs: void }
 - hint: { lhs: return, rhs: pure }

Makefile

@@ -117,6 +117,22 @@ cabal-fmt:
 ghcid:
 	ghcid -l=hlint --command "cabal repl $(target)"
 
+.PHONY: hlint-check-all
+hlint-check-all:
+	./tools/hlint.sh -f all -m check
+
+.PHONY: hlint-inplace-all
+hlint-inplace-all:
+	./tools/hlint.sh -f all -m inplace
+
+.PHONY: hlint-check
+hlint-check:
+	./tools/hlint.sh -f changeset -m check
+
+.PHONY: hlint-inplace
+hlint-inplace:
+	./tools/hlint.sh -f changeset -m inplace
+
 # reset db using cabal
 .PHONY: db-reset-package
 db-reset-package: c

libs/api-bot/src/Network/Wire/Bot/Assert.hs

@@ -1,5 +1,4 @@
 {-# LANGUAGE LambdaCase #-}
-{-# LANGUAGE OverloadedStrings #-}
 
 -- This file is part of the Wire Server implementation.
 --

libs/api-bot/src/Network/Wire/Bot/Cache.hs

@@ -1,3 +1,4 @@
+{-# LANGUAGE LambdaCase #-}
 {-# LANGUAGE OverloadedStrings #-}
 
 -- This file is part of the Wire Server implementation.
@@ -64,13 +65,12 @@ empty :: IO Cache
 empty = Cache <$> newIORef []
 
 get :: (MonadIO m, HasCallStack) => Cache -> m CachedUser
-get c = liftIO . atomicModifyIORef (cache c) $ \u ->
-  case u of
-    [] ->
-      error
-        "Cache.get: an account was requested from the cache, \
-        \but the cache of available user accounts is empty"
-    (x : xs) -> (xs, x)
+get c = liftIO . atomicModifyIORef (cache c) $ \case
+  [] ->
+    error
+      "Cache.get: an account was requested from the cache, \
+      \but the cache of available user accounts is empty"
+  (x : xs) -> (xs, x)
 
 put :: MonadIO m => Cache -> CachedUser -> m ()
 put c a = liftIO . atomicModifyIORef (cache c) $ \u -> (a : u, ())

libs/api-client/src/Network/Wire/Client/Monad.hs

@@ -1,6 +1,5 @@
 {-# LANGUAGE DeriveDataTypeable #-}
 {-# LANGUAGE GeneralizedNewtypeDeriving #-}
-{-# LANGUAGE OverloadedStrings #-}
 
 -- This file is part of the Wire Server implementation.
 --

libs/bilge/src/Bilge/Request.hs

@@ -156,7 +156,7 @@ expectStatus property r = r {Rq.checkResponse = check}
       | property (HTTP.statusCode (Rq.responseStatus res)) = pure ()
       | otherwise = do
         some <- Lazy.toStrict <$> brReadSome (Rq.responseBody res) 1024
-        throwHttp $ Rq.StatusCodeException (() <$ res) some
+        throwHttp $ Rq.StatusCodeException (void res) some
 
 checkStatus :: (Status -> ResponseHeaders -> CookieJar -> Maybe SomeException) -> Request -> Request
 checkStatus f r = r {Rq.checkResponse = check}

libs/brig-types/src/Brig/Types/Common.hs

@@ -80,7 +80,7 @@ isValidPhonePrefix = isRight . parseOnly e164Prefix
 -- | get all valid prefixes of a phone number or phone number prefix
 -- e.g. from +123456789 get prefixes ["+1", "+12", "+123", ..., "+123456789" ]
 allPrefixes :: Text -> [PhonePrefix]
-allPrefixes t = catMaybes $ parsePhonePrefix <$> Text.inits t
+allPrefixes t = mapMaybe parsePhonePrefix (Text.inits t)
 
 instance FromJSON PhonePrefix where
   parseJSON = withText "PhonePrefix" $ \s ->

libs/extended/src/Servant/API/Extended.hs

@@ -94,18 +94,18 @@ instance
                   requestHeaders request
         case canHandleCTypeH (Proxy :: Proxy list) (cs contentTypeH) :: Maybe (BL.ByteString -> Either String a) of
           Nothing -> delayedFail err415
-          Just f -> return f
+          Just f -> pure f
       -- Body check, we get a body parsing functions as the first argument.
       bodyCheck ::
         (BL.ByteString -> Either String a) ->
         DelayedIO (If (FoldLenient mods) (Either ServerError a) a)
       bodyCheck f = withRequest $ \request -> do
         mrqbody <- fmapL (makeCustomError @tag @a) . f <$> liftIO (lazyRequestBody request)
         case sbool :: SBool (FoldLenient mods) of
-          STrue -> return mrqbody
+          STrue -> pure mrqbody
           SFalse -> case mrqbody of
             Left e -> delayedFailFatal e
-            Right v -> return v
+            Right v -> pure v
 
 instance
   HasSwagger (ReqBody' '[Required, Strict] cts a :> api) =>

libs/hscim/src/Web/Scim/Client.hs

@@ -75,7 +75,7 @@ type HasScimClient tag =
   )
 
 scimClients :: HasScimClient tag => ClientEnv -> Site tag (AsClientT IO)
-scimClients env = genericClientHoist $ \x -> runClientM x env >>= either throwIO return
+scimClients env = genericClientHoist $ \x -> runClientM x env >>= either throwIO pure
 
 -- config
 
@@ -130,7 +130,7 @@ postUser ::
   HasScimClient tag =>
   ClientEnv ->
   Maybe (AuthData tag) ->
-  (User tag) ->
+  User tag ->
   IO (StoredUser tag)
 postUser env tok = case users (scimClients env) tok of ((_ :<|> (_ :<|> r)) :<|> (_ :<|> (_ :<|> _))) -> r
 
@@ -139,7 +139,7 @@ putUser ::
   ClientEnv ->
   Maybe (AuthData tag) ->
   UserId tag ->
-  (User tag) ->
+  User tag ->
   IO (StoredUser tag)
 putUser env tok = case users (scimClients env) tok of ((_ :<|> (_ :<|> _)) :<|> (r :<|> (_ :<|> _))) -> r
 

libs/hscim/src/Web/Scim/ContentType.hs

@@ -14,6 +14,9 @@
 --
 -- You should have received a copy of the GNU Affero General Public License along
 -- with this program. If not, see <https://www.gnu.org/licenses/>.
+{-# OPTIONS_GHC -Wno-unrecognised-pragmas #-}
+
+{-# HLINT ignore "Use list literal" #-}
 
 -- | SCIM defines its own content type (application/scim+json). It's
 -- intended to be used for all requests and responses; see the first