Skip to content

Add mls-test-cli to deps image #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2022
Merged

Add mls-test-cli to deps image #2630

merged 2 commits into from
Aug 18, 2022

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Aug 18, 2022 •
edited
Loading

Followup to #2626 (which removed mls-test-cli from the deps image). mls-test-cli is also needed in the deps image for integration tests.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@smatting smatting added the not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR label Aug 18, 2022
@smatting smatting marked this pull request as ready for review August 18, 2022 13:46
@smatting smatting temporarily deployed to cachix August 18, 2022 13:46 Inactive
@smatting smatting temporarily deployed to cachix August 18, 2022 13:46 Inactive
@smatting smatting merged commit 22a8685 into develop Aug 18, 2022
@smatting smatting deleted the smatting/mls-test-cli-deps branch August 18, 2022 13:48
@zebot zebot mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

+1 more reviewer

@stephen-smith stephen-smith stephen-smith approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smatting @stephen-smith @akshaymankar