Skip to content

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Aug 17, 2022

Motivation: Unit tests are run in the builder image. We'd like to use the mls-test-cli in unit tests.

This PR can be tested locally by running

docker build --build-arg prebuilder=quay.io/wire/ubuntu20-prebuilder:develop -f ./Dockerfile.builder .

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@smatting smatting temporarily deployed to cachix August 17, 2022 15:51 Inactive
@smatting smatting temporarily deployed to cachix August 17, 2022 15:51 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 17, 2022
@smatting smatting force-pushed the FS-832-mls-test-cli-builder-image branch from 003f037 to eaeab25 Compare August 17, 2022 16:01
@smatting smatting temporarily deployed to cachix August 17, 2022 16:01 Inactive
@smatting smatting temporarily deployed to cachix August 17, 2022 16:01 Inactive
@smatting smatting added the not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR label Aug 17, 2022
@smatting smatting marked this pull request as ready for review August 17, 2022 16:02
@smatting smatting requested a review from pcapriotti August 17, 2022 16:02
@smatting smatting temporarily deployed to cachix August 17, 2022 16:05 Inactive
@smatting smatting temporarily deployed to cachix August 17, 2022 16:05 Inactive
@smatting smatting merged commit 70f5e3e into develop Aug 18, 2022
@smatting smatting deleted the FS-832-mls-test-cli-builder-image branch August 18, 2022 07:50
@smatting smatting mentioned this pull request Aug 18, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants