[SQServices-1627] Check remaining time of an activated a feature in back office

[elland]

The changes to the feature endpoint is backward compatible and shouldn't require any specific deploy order.

Checklist

• The PR Title explains the impact of the change.
• The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
• changelog.d contains the following bits of information (details):
• If public end-points have been changed or added: does nginz need un upgrade?
• If internal end-points have been added or changed: which services have to be deployed in a specific order?

[fisx]

did you run the unit tests locally?

==== Testing galley-types...
#10 490.3 Tests
#10 490.3   Tests
#10 490.3     owner has all permissions:                                                          OK
#10 490.3     smaller roles (further to the left/top in the type def) are strictly more powerful: OK
#10 490.3     FeatureFlags:                                                                       FAIL (0.01s)
#10 490.3       *** Failed! Falsified (after 1 test):
#10 490.3       FeatureFlags {_flagSSO = FeatureSSODisabledByDefault, _flagLegalHold = FeatureLegalHoldWhitelistTeamsAndImplicitConsent, _flagTeamSearchVisibility = FeatureTeamSearchVisibilityUnavailableByDefault, _flagAppLockDefaults = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (AppLockConfig {applockEnforceAppLock = EnforceAppLock True, applockInactivityTimeoutSecs = -1}), wsbTTL = Identity FeatureTTLUnlimited}}, _flagClassifiedDomains = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (ClassifiedDomainsConfig {classifiedDomainsDomains = []}), wsbTTL = Identity (FeatureTTLSeconds 0)}, _flagFileSharing = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity FileSharingConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagConferenceCalling = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity ConferenceCallingConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagSelfDeletingMessages = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (SelfDeletingMessagesConfig {sdmEnforcedTimeoutSeconds = 0}), wsbTTL = Identity (FeatureTTLSeconds 0)}}, _flagConversationGuestLinks = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity GuestLinksConfig, wsbTTL = Identity (FeatureTTLSeconds 0)}}, _flagsTeamFeatureValidateSAMLEmailsStatus = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity ValidateSAMLEmailsConfig, wsbTTL = Identity (FeatureTTLSeconds 0)}}, _flagTeamFeatureSndFactorPasswordChallengeStatus = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusLocked, wsbConfig = Identity SndFactorPasswordChallengeConfig, wsbTTL = Identity (FeatureTTLSeconds 0)}}, _flagTeamFeatureSearchVisibilityInbound = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity SearchVisibilityInboundConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagMLS = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (MLSConfig {mlsProtocolToggleUsers = [], mlsDefaultProtocol = ProtocolMLSTag, mlsAllowedCipherSuites = [], mlsDefaultCipherSuite = MLS_128_DHKEMX25519_AES128GCM_SHA256_Ed25519}), wsbTTL = Identity (FeatureTTLSeconds 0)}}}
#10 490.3       Object (fromList [("appLock",Object (fromList [("defaults",Object (fromList [("config",Object (fromList [("enforceAppLock",Bool True),("inactivityTimeoutSecs",Number (-1.0))])),("status",String "enabled"),("ttl",String "unlimited")]))])),("classifiedDomains",Object (fromList [("config",Object (fromList [("domains",Array [])])),("status",String "disabled"),("ttl",String "unlimited")])),("conferenceCalling",Object (fromList [("defaults",Object (fromList [("status",String "disabled"),("ttl",String "unlimited")]))])),("conversationGuestLinks",Object (fromList [("defaults",Object (fromList [("lockStatus",String "unlocked"),("status",String "enabled"),("ttl",String "unlimited")]))])),("fileSharing",Object (fromList [("defaults",Object (fromList [("lockStatus",String "unlocked"),("status",String "enabled"),("ttl",String "unlimited")]))])),("legalhold",String "whitelist-teams-and-implicit-consent"),("mls",Object (fromList [("defaults",Object (fromList [("config",Object (fromList [("allowedCipherSuites",Array []),("defaultCipherSuite",Number 1.0),("defaultProtocol",String "mls"),("protocolToggleUsers",Array [])])),("status",String "disabled"),("ttl",String "unlimited")]))])),("searchVisibilityInbound",Object (fromList [("defaults",Object (fromList [("status",String "disabled"),("ttl",String "unlimited")]))])),("selfDeletingMessages",Object (fromList [("defaults",Object (fromList [("config",Object (fromList [("enforcedTimeoutSeconds",Number 0.0)])),("lockStatus",String "unlocked"),("status",String "disabled"),("ttl",String "unlimited")]))])),("sndFactorPasswordChallenge",Object (fromList [("defaults",Object (fromList [("lockStatus",String "locked"),("status",String "disabled"),("ttl",String "unlimited")]))])),("sso",String "disabled-by-default"),("teamSearchVisibility",String "disabled-by-default"),("validateSAMLEmails",Object (fromList [("defaults",Object (fromList [("status",String "enabled"),("ttl",String "unlimited")]))]))])
#10 490.3       Right (FeatureFlags {_flagSSO = FeatureSSODisabledByDefault, _flagLegalHold = FeatureLegalHoldWhitelistTeamsAndImplicitConsent, _flagTeamSearchVisibility = FeatureTeamSearchVisibilityUnavailableByDefault, _flagAppLockDefaults = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (AppLockConfig {applockEnforceAppLock = EnforceAppLock True, applockInactivityTimeoutSecs = -1}), wsbTTL = Identity FeatureTTLUnlimited}}, _flagClassifiedDomains = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (ClassifiedDomainsConfig {classifiedDomainsDomains = []}), wsbTTL = Identity (FeatureTTLSeconds 0)}, _flagFileSharing = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity FileSharingConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagConferenceCalling = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity ConferenceCallingConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagSelfDeletingMessages = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (SelfDeletingMessagesConfig {sdmEnforcedTimeoutSeconds = 0}), wsbTTL = Identity (FeatureTTLSeconds 0)}}, _flagConversationGuestLinks = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity GuestLinksConfig, wsbTTL = Identity (FeatureTTLSeconds 0)}}, _flagsTeamFeatureValidateSAMLEmailsStatus = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity ValidateSAMLEmailsConfig, wsbTTL = Identity (FeatureTTLSeconds 0)}}, _flagTeamFeatureSndFactorPasswordChallengeStatus = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusLocked, wsbConfig = Identity SndFactorPasswordChallengeConfig, wsbTTL = Identity (FeatureTTLSeconds 0)}}, _flagTeamFeatureSearchVisibilityInbound = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity SearchVisibilityInboundConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagMLS = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (MLSConfig {mlsProtocolToggleUsers = [], mlsDefaultProtocol = ProtocolMLSTag, mlsAllowedCipherSuites = [], mlsDefaultCipherSuite = MLS_128_DHKEMX25519_AES128GCM_SHA256_Ed25519}), wsbTTL = Identity (FeatureTTLSeconds 0)}}}) /= Right (FeatureFlags {_flagSSO = FeatureSSODisabledByDefault, _flagLegalHold = FeatureLegalHoldWhitelistTeamsAndImplicitConsent, _flagTeamSearchVisibility = FeatureTeamSearchVisibilityUnavailableByDefault, _flagAppLockDefaults = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (AppLockConfig {applockEnforceAppLock = EnforceAppLock True, applockInactivityTimeoutSecs = -1}), wsbTTL = Identity FeatureTTLUnlimited}}, _flagClassifiedDomains = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (ClassifiedDomainsConfig {classifiedDomainsDomains = []}), wsbTTL = Identity FeatureTTLUnlimited}, _flagFileSharing = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity FileSharingConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagConferenceCalling = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity ConferenceCallingConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagSelfDeletingMessages = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (SelfDeletingMessagesConfig {sdmEnforcedTimeoutSeconds = 0}), wsbTTL = Identity FeatureTTLUnlimited}}, _flagConversationGuestLinks = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity GuestLinksConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagsTeamFeatureValidateSAMLEmailsStatus = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusEnabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity ValidateSAMLEmailsConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagTeamFeatureSndFactorPasswordChallengeStatus = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusLocked, wsbConfig = Identity SndFactorPasswordChallengeConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagTeamFeatureSearchVisibilityInbound = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity SearchVisibilityInboundConfig, wsbTTL = Identity FeatureTTLUnlimited}}, _flagMLS = Defaults {_unDefaults = WithStatusBase {wsbStatus = Identity FeatureStatusDisabled, wsbLockStatus = Identity LockStatusUnlocked, wsbConfig = Identity (MLSConfig {mlsProtocolToggleUsers = [], mlsDefaultProtocol = ProtocolMLSTag, mlsAllowedCipherSuites = [], mlsDefaultCipherSuite = MLS_128_DHKEMX25519_AES128GCM_SHA256_Ed25519}), wsbTTL = Identity FeatureTTLUnlimited}}})
#10 490.3       Use --quickcheck-replay=237033 to reproduce.
#10 490.3       Use -p '/FeatureFlags/' to rerun this test only.

[fisx]

this is also impossible, right?

[fisx]

ah, i see. i got that wrong earlier, thanks!

[battermann]