Better handle ttl = 0.

Author: elland

libs/wire-api/src/Wire/API/Team/Feature.hs

@@ -354,7 +354,12 @@ data FeatureTTL
   = FeatureTTLSeconds Word
   | FeatureTTLUnlimited
   deriving stock (Eq, Show, Generic)
-  deriving (Arbitrary) via (GenericUniform FeatureTTL)
+
+instance Arbitrary FeatureTTL where
+  arbitrary = nonZero <$> arbitrary
+    where
+      nonZero 0 = FeatureTTLUnlimited
+      nonZero n = FeatureTTLSeconds n
 
 instance ToSchema FeatureTTL where
   schema = mkSchema ttlDoc toTTL fromTTL
@@ -376,9 +381,9 @@ instance ToSchema FeatureTTL where
       parseSeconds :: A.Value -> A.Parser FeatureTTL
       parseSeconds = A.withScientific "FeatureTTL" $
         \s -> case toBoundedInteger s of
-          Just 0 -> pure FeatureTTLUnlimited
+          Just 0 -> A.parseFail "Expected a positive integer. Got 0 instead."
           Just i -> pure . FeatureTTLSeconds $ i
-          Nothing -> A.parseFail "Expected an integer."
+          Nothing -> A.parseFail "Expected an positive integer."
 
       fromTTL :: FeatureTTL -> Maybe A.Value
       fromTTL FeatureTTLUnlimited = Just "unlimited"