-
Notifications
You must be signed in to change notification settings - Fork 333
Use cabal to build wire-server (opt-in) #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will affect #1852, but i think we can work on it in parallel. getting all the dependencies in shape for ghc10 and all the new packages will still be required, right? |
b2b2cf4
to
6a50129
Compare
akshaymankar
reviewed
Nov 1, 2021
mdimjasevic
reviewed
Nov 2, 2021
6b1ff20
to
00f092e
Compare
00f092e
to
9f28d1d
Compare
12 tasks
9f28d1d
to
981a74e
Compare
981a74e
to
3ca1a83
Compare
akshaymankar
reviewed
Nov 8, 2021
Both `cabal test` and `cabal install` "change configuration" so next time `cabal build` is run, cabal goes over all the packages to make sure nothing needs compilation which is a significant slowdown. This way we don't have to go through that slowdown.
akshaymankar
approved these changes
Nov 8, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should enable us to try using cabal instead of stack locally.
This PR:
stack2cabal
toolcabal.project
andcabal.freeze
file generated by stack2cabalWIRE_BUILD_WITH_CABAL
that is, When it is setcabal
will be used formake fast
andmake install
from the root Makefile.cabal
to build:package.yaml
oftypes-common-journal
andwire-message-proto-lens
, because the cabal files generated withhpack
don't work with cabal.For details see
tools/convert-to-cabal/README.md
included in this PR.Building with cabal has been tested only locally. For building on CI/withou nix follow-up PRs are needed.
Checklist