Skip to content

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Oct 11, 2021

As the only bindists for GHC 8.10.7 on Alpine Linux are for integer-simple and migrating to integer-simple is some work, this PR swaps out the Alpine docker images with Ubuntu 20.04 based docker images. As Ubuntu is a much more widely used distribution among haskellers, we hope for better support from community for this.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@mdimjasevic
Copy link
Contributor

@fisx , is this still a draft?

@fisx
Copy link
Contributor Author

fisx commented Nov 1, 2021

yes. i was hoping this would be easy, but it wasn't. don't remember what i got stuck with.

@fisx
Copy link
Contributor Author

fisx commented Nov 30, 2021

I don't understand the following error:

In the dependencies for MonadRandom-0.5.3:
    random dependency cycle detected: random, splitmix, random, mime-mail, HaskellNet, api-bot
needed due to brig-1.35.0 -> MonadRandom-0.5.3

@fisx
Copy link
Contributor Author

fisx commented Nov 30, 2021

The above error was with amazonka from hackage. Now I am running make on 6271587, and stack 2.3.1 is hanging here:

Cloning 412172d8c28906591f01576a78792de7c34cc3eb from https://github.com/wireapp/amazonka

stack-2.7.3 works better.

@fisx
Copy link
Contributor Author

fisx commented Nov 30, 2021

cryptohash                       > /tmp/stack-0a980421e8d42b9e/cryptohash-0.11.9/cbits/sha512.c:235:29: error:          
cryptohash                       >      warning: ‘%d’ directive writing between 1 and 11 bytes into a region of size 4 [-Wformat-overflow=]
cryptohash                       >       235 |   i = sprintf(buf, "SHA-512/%d", t);                                     
cryptohash                       >           |                             ^~                                           
cryptohash                       >     |                                                                                
cryptohash                       > 235 |                 i = sprintf(buf, "SHA-512/%d", t);                             
cryptohash                       >     |                             ^                                                  
cryptohash                       >                                                                                      
cryptohash                       > /tmp/stack-0a980421e8d42b9e/cryptohash-0.11.9/cbits/sha512.c:235:20: error:          
cryptohash                       >      note: directive argument in the range [-2147483648, 511]                        
cryptohash                       >       235 |   i = sprintf(buf, "SHA-512/%d", t);                                     
cryptohash                       >           |                    ^~~~~~~~~~~~                                          
cryptohash                       >     |                                                                                
cryptohash                       > 235 |                 i = sprintf(buf, "SHA-512/%d", t);                             
cryptohash                       >     |                    ^                                                           
cryptohash                       > In file included from /nix/store/f8ahd6cxx9ia4fzdiyczmhcv3c2qmd42-glibc-2.32-37-dev/include/stdio.h:866,
cryptohash                       >                                                                                      
cryptohash                       > /tmp/stack-0a980421e8d42b9e/cryptohash-0.11.9/                 from cbits/sha512.c:197:0: error: 
cryptohash                       >                                                                                      
cryptohash                       > /tmp/stack-0a980421e8d42b9e/cryptohash-0.11.9//nix/store/f8ahd6cxx9ia4fzdiyczmhcv3c2qmd42-glibc-2.32-37-dev/include/bits/stdio2.h:38:10: error:
cryptohash                       >      note: ‘__builtin___sprintf_chk’ output between 10 and 20 bytes into a destination of size 12
cryptohash                       >        38 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,          
cryptohash                       >           |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~          
cryptohash                       >        39 |       __bos (__s), __fmt, __va_arg_pack ());                             
cryptohash                       >           |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                              
cryptohash                       >    |                                                                                 
cryptohash                       > 38 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,                 
cryptohash                       >    |          ^                                                                      

@fisx
Copy link
Contributor Author

fisx commented Nov 30, 2021

(maybe try cryptohash head from github main branch?)

@fisx
Copy link
Contributor Author

fisx commented Nov 30, 2021

amazonka-ses                     > [17 of 75] Compiling Network.AWS.SES.SendBounce          
                                                                                            
Warning: Failed to decode module interface:
         /home/mf/src/wire-server/libs/types-common-aws/.stack-work/dist/x86_64-linux-nix-tinfo6/Cabal-3.2.1.0/build/Util/Test/SQS.hi
         Decoding failure: Invalid magic: e49ceb0f

@fisx fisx changed the title bump stackage (16.14 -> 18.13) bump stackage (16.14 -> 18.18) Dec 7, 2021
@fisx
Copy link
Contributor Author

fisx commented Dec 7, 2021

warning: we may have to use stack-2.7.3 or whatever's up to date now.

@akshaymankar akshaymankar changed the title bump stackage (16.14 -> 18.18) Bump stackage from 16.14 to 18.18 Jan 5, 2022
@akshaymankar akshaymankar changed the title Bump stackage from 16.14 to 18.18 Upgrade to GHC 8.10 and use Ubuntu 20.04 as base image for haskell docker images Jan 5, 2022
@akshaymankar
Copy link
Member

akshaymankar commented Jan 5, 2022

Please ignore the main PR pipeline and the status check, it will not work with these changes. There is a separate pipeline for this branch here: https://bridge-ie-concourse.zinfra.io/teams/main/pipelines/wire-server-ghc8107. When this PR gets merged, I will update the PR pipeline and other build pipelines.

@akshaymankar akshaymankar marked this pull request as ready for review January 5, 2022 11:29
Copy link
Contributor Author

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshaymankar feel free to approve it yourself; I can't since I started the PR :)

(small commit resolving the conflicts coming up.)

@fisx
Copy link
Contributor Author

fisx commented Jan 10, 2022

last commit is wrong, in order for direnv to pick up the changes you need to leave the directory and come back. i'll try again when i'm dong building.

@akshaymankar
Copy link
Member

last commit is wrong, in order for direnv to pick up the changes you need to leave the directory and come back. i'll try again when i'm dong building.

Hmm, we need to add a bunch of watch_file commands to the .envrc.

@fisx
Copy link
Contributor Author

fisx commented Jan 13, 2022

any other blockers? i say :shipit:, but you'll have to formally approve since i created the PR.

@akshaymankar
Copy link
Member

any other blockers? i say :shipit:, but you'll have to formally approve since i created the PR.

I am planning to :shipit: on Monday, because I suspect I will have to baby sit some pipeline changes to be made in order and I don't want to leave things broken when I am not around.

Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On behalf of @fisx

@smatting smatting mentioned this pull request Jan 17, 2022
12 tasks
@akshaymankar akshaymankar merged commit 194f9da into develop Jan 17, 2022
@akshaymankar akshaymankar deleted the bump-stackage branch January 17, 2022 10:13
@akshaymankar akshaymankar mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants