Skip to content

core(deps): Use Go 1.18 #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 18, 2022
Merged

core(deps): Use Go 1.18 #769

merged 6 commits into from
May 18, 2022

Conversation

yitsushi
Copy link
Contributor

@yitsushi yitsushi commented May 17, 2022

Local development notes:

  • If you are using go 1.18 and all your installed binaries (golint for example) was compiled with 1.18 you have nothing to do
  • If you are using go 1.18, but some of your tools were installed/compiled with 1.17, you have to re-compile them
  • If you are using go 1.18, some of your tools were installed/compiled with 1.17, but you updated them after you moved to 1.18, you have nothing to do
  • if you are still using go 1.17, you have to update go version to 1.18 and re-compile your binaries

Closes #763

@yitsushi yitsushi added the dependencies Pull requests that update a dependency file label May 17, 2022
@yitsushi yitsushi requested a review from yiannistri May 17, 2022 12:06
@yitsushi yitsushi added the enhancement New feature or request label May 17, 2022
Copy link
Collaborator

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 cc @foot

@@ -3,8 +3,12 @@
set -e

GOPATH=$(go env GOPATH)
GOLANGCI_LINT_VERSION="v1.46.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@yitsushi yitsushi requested a review from foot May 17, 2022 13:00
@foot
Copy link
Collaborator

foot commented May 17, 2022

Wicked! Maybe update CONTRIB.md too.

Any other transitional notes? I remember going to 1.17 (?) we had to go mod tidy -compat or something..

@foot
Copy link
Collaborator

foot commented May 17, 2022

Seems a bit faster building the golang docker images ✨

@yitsushi
Copy link
Contributor Author

yitsushi commented May 17, 2022

Any other transitional notes? I remember going to 1.17 (?) we had to go mod tidy -compat or something..

I don't think, I just run go mod tidy once in directories with go.mod file. Running (now) go mod tidy -compat=1.18 did not change mod or sum files.

Maybe update CONTRIB.md too.

Updated.

@yitsushi yitsushi merged commit cb47c5a into main May 18, 2022
@yitsushi yitsushi deleted the use-go-1-18 branch May 18, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build to use Go 1.18
3 participants