-
Notifications
You must be signed in to change notification settings - Fork 2
core(deps): Use Go 1.18 #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes #763
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 cc @foot
@@ -3,8 +3,12 @@ | |||
set -e | |||
|
|||
GOPATH=$(go env GOPATH) | |||
GOLANGCI_LINT_VERSION="v1.46.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Wicked! Maybe update CONTRIB.md too. Any other transitional notes? I remember going to 1.17 (?) we had to |
Seems a bit faster building the golang docker images ✨ |
I don't think, I just run
Updated. |
Local development notes:
golint
for example) was compiled with 1.18 you have nothing to doCloses #763