Update build to use Go 1.18

[yiannistri]

Go 1.18 includes support for generics. This story is about changing the CI process to use Go 1.18 and fixing any issues that may arise as a result of the update.

[yitsushi]

A lot of linters are still disabled by default on go 1.18 with golangci-lint. Are we ready to accept none of them will be checked?

❯ golangci-lint run 2>&1 | grep -oE "[a-z]+ is disabled because of go1.18" | cut -d " " -f 1 | sort
bodyclose
contextcheck
gosimple
interfacer
nilerr
noctx
rowserrcheck
sqlclosecheck
staticcheck
structcheck
stylecheck
tparallel
unparam
unused
wastedassign

So before we start working on go 1.18 migration, we have to explicitly say "we know and acknowledge those consequences"

golangci-lint migration issue: golangci/golangci-lint#2649

[yiannistri]

Ok that's a valid point. Looking at the current golangci-lint configuration in a recent PR we only have a small subset of the whole suite enabled. Not sure if that's because of time constraints.

level=info msg="[lintersdb] Active 12 linters: [deadcode errcheck gofmt gosimple govet ineffassign misspell staticcheck structcheck typecheck unused varcheck]"

I'm inclined to:

• wait until these issues get addressed
• enable other linters that don't currently run in this repo to make things consistent with core

[yitsushi]

Updated my golangci-lint to v1.16.1, on core it seems only one linter gets disabled:

❯ golangci-lint version && golangci-lint run 2>&1 | grep -oE "[a-z]+ is disabled because of go1.18" | cut -d " " -f 1 | sort
golangci-lint has version v1.46.1 built from (unknown, mod sum: "h1:sc3XD0pprdZuqZkl6snUfnmUT1XW4dTTyLeOBvxn+3M=") on (unknown)
structcheck

Same one wge:

❯ golangci-lint run 2>&1 | grep -oE "[a-z]+ is disabled because of go1.18" | cut -d " " -f 1 | sort
structcheck

[yiannistri]

@yitsushi can you create a PR and try this out? Missing out on a single linter that checks for unused struct fields in new code is not too bad in my opinion, given the benefit of getting a version of Go that supports generics and a more up to date linter suite.