Skip to content

TLS support for clusters-service #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Mar 11, 2022
Merged

TLS support for clusters-service #538

merged 46 commits into from
Mar 11, 2022

Conversation

foot
Copy link
Collaborator

@foot foot commented Mar 8, 2022

Fixes #532

  • Modifies build process, now builds a gitops binary in a workflow if you need a ref other than main
    • Simon, 2022-03-11: This is locked to weaveworks/weave-gitops@931b52e (main) right now as a main has failed to build a new gitops binary due to more gitlab account locking.
  • Removes the nginx-ingress-controller
    • Disables the alerting acceptance tests for now as they rely on the ingress-controller to talk to alertmanager
  • clusters-service listens to TLS by default
  • Helm chart updated w/ tls section where you can specify a TLS secret (e.g. as generated by cert-manager)
    tls:
      enabled: true
      # if no tls secret is specified then we generate it in-mem in the server
      secretName: ""
    

User-guide updates are in weaveworks/weave-gitops#1689

@foot foot added the enhancement New feature or request label Mar 8, 2022
Base automatically changed from auth-integration to main March 8, 2022 13:34
Copy link
Collaborator

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯 💯 💯

@foot foot merged commit 7b3e86c into main Mar 11, 2022
@foot foot deleted the tls-support branch March 11, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring TLS support in from CORE
2 participants