-
Notifications
You must be signed in to change notification settings - Fork 2
Adds the PR template from weave-gitops to this repo #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
<!-- | ||
Use # to add the issue this pull request is related to. | ||
nb: This is the Github issue number, not a Zenhub link. | ||
Do not use any punctuation or bullet points. | ||
eg: | ||
Closes #1234 | ||
Fixes #5678 | ||
--> | ||
Closes | ||
|
||
<!-- Describe what has changed in this PR --> | ||
**What changed?** | ||
|
||
|
||
<!-- Tell your future self why have you made these changes --> | ||
**Why was this change made?** | ||
|
||
|
||
<!-- | ||
Explain to your reviewers the key implementation points, including why you made | ||
certain choices in favour of others. Highlight key areas of the code which need | ||
extra attention, and also indicate which parts are less relevant (eg renaming, | ||
refactoring, etc | ||
--> | ||
**How was this change implemented?** | ||
|
||
|
||
<!-- | ||
How have you verified this change/product value? Tested locally? | ||
Added integration/acceptance test(s)? | ||
Unit tests are required. | ||
--> | ||
**How did you validate the change?** | ||
|
||
|
||
<!-- | ||
Is it notable for release? e.g. schema updates, configuration or data migration | ||
required? If so, please mention it. | ||
--> | ||
**Release notes** | ||
|
||
|
||
<!-- Are there any documentation updates that should be made for these changes? --> | ||
foot marked this conversation as resolved.
Show resolved
Hide resolved
|
||
**Documentation Changes** | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it might makes sense to extend documentation as
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.