Adds the PR template from weave-gitops to this repo #1501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It works quite well to get you to think through their changes a bit before asking for more eyes on it
foot
added
the
exclude from release notes
serboctor
approved these changes
Sep 12, 2022
ozamosi
approved these changes
Sep 12, 2022
enekofb
reviewed
Sep 13, 2022
|
|
||
|
|
||
| <!-- Are there any documentation updates that should be made for these changes? --> | ||
| **Documentation Changes** |
There was a problem hiding this comment.
it might makes sense to extend documentation as
- weave gitiops user documentation https://docs.gitops.weave.works/
- weave gitops internal documentation as in https://github.com/weaveworks/weave-gitops-enterprise/tree/main/docs
yiannistri
reviewed
Sep 13, 2022
There was a problem hiding this comment.
@foot I'd suggest we also prompt engineers to include some screenshots when there are UI changes, it would be very helpful during reviews.
foot
commented
Sep 19, 2022
foot
commented
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.