-
Notifications
You must be signed in to change notification settings - Fork 2
Flag for editing values in Required Profiles #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5b4079b
Add editableValues to Template Profiles
AlinaGoaga 5955022
Add editableValues to Template Profiles - updated
AlinaGoaga 2cec4ae
Merge branch 'main' of github.com:weaveworks/weave-gitops-enterprise …
AlinaGoaga a1fd874
Update ProfileListItem to look for editable values
AlinaGoaga d00ee3e
Update flag
AlinaGoaga 0afa472
Merge branch 'main' into WG1086-editable-values-flag
AlinaGoaga 3123698
Update ui-cra/src/components/Clusters/Create/Form/Partials/ProfileLis…
AlinaGoaga 9860bd7
Check that user edited values are in fact editable
AlinaGoaga 4705ab7
Merge branch 'WG1086-editable-values-flag' of github.com:weaveworks/w…
AlinaGoaga 5aad121
Check that user edited values are in fact editable - 2
AlinaGoaga 16861fe
Adds a test case for editable
foot 7911634
Add test for GenerateProfileFiles
AlinaGoaga e11a946
Merge branch 'main' into WG1086-editable-values-flag
AlinaGoaga 740638e
Regenate files
AlinaGoaga dee670e
Update tests
AlinaGoaga ba773f0
Refactor handling of editable flag
AlinaGoaga 1ec0f41
Merge branch 'main' into WG1086-editable-values-flag
AlinaGoaga 9e56104
Refactor handling of editable flag -
AlinaGoaga 83e2249
Merge branch 'main' into WG1086-editable-values-flag
AlinaGoaga 7798565
Regen file
AlinaGoaga 8089f72
Fix typo
AlinaGoaga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1609,6 +1609,9 @@ | |
}, | ||
"version": { | ||
"type": "string" | ||
}, | ||
"editable": { | ||
"type": "boolean" | ||
} | ||
} | ||
} | ||
|
672 changes: 341 additions & 331 deletions
672
cmd/clusters-service/pkg/protos/cluster_services.pb.go
Large diffs are not rendered by default.
Oops, something went wrong.
180 changes: 108 additions & 72 deletions
180
cmd/clusters-service/pkg/protos/cluster_services.pb.gw.go
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.