Skip to content

Flag for editing values in Required Profiles #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 29, 2022

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Jul 22, 2022

Closes #1086

@AlinaGoaga AlinaGoaga added the enhancement New feature or request label Jul 22, 2022
@AlinaGoaga AlinaGoaga marked this pull request as ready for review July 22, 2022 14:36
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! ⭐

Lets also tighten up the BE a bit,

E.g. here

if v.Values == "" {
v.Values, err = getDefaultValues(ctx, kubeClient, v.Name, v.Version, args.helmRepositoryCacheDir, sourceRef, helmRepo)
we can use
func getProfilesFromTemplate(annotations map[string]string) ([]*capiv1_proto.TemplateProfile, error) {
profiles := []*capiv1_proto.TemplateProfile{}
to pull the OG editable value out and ignore the user supplied values in present. If that makes sense?

Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

@AlinaGoaga AlinaGoaga merged commit e8390d7 into main Jul 29, 2022
@AlinaGoaga AlinaGoaga deleted the WG1086-editable-values-flag branch July 29, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow required profiles with user defined values.yaml
2 participants