-
Notifications
You must be signed in to change notification settings - Fork 2
Flag for editing values in Required Profiles #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ui-cra/src/components/Clusters/Create/Form/Partials/ProfileListItem.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! ⭐
Lets also tighten up the BE a bit,
E.g. here
weave-gitops-enterprise/cmd/clusters-service/pkg/server/clusters.go
Lines 512 to 513 in 5bc603f
if v.Values == "" { | |
v.Values, err = getDefaultValues(ctx, kubeClient, v.Name, v.Version, args.helmRepositoryCacheDir, sourceRef, helmRepo) |
weave-gitops-enterprise/cmd/clusters-service/pkg/server/templates.go
Lines 170 to 171 in 5bc603f
func getProfilesFromTemplate(annotations map[string]string) ([]*capiv1_proto.TemplateProfile, error) { | |
profiles := []*capiv1_proto.TemplateProfile{} |
…tItem.tsx Co-authored-by: Simon <[email protected]>
…eave-gitops-enterprise into WG1086-editable-values-flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 !
Closes #1086