Skip to content

Conversation

Shrutim1505
Copy link
Member

@Shrutim1505 Shrutim1505 commented May 8, 2025

This PR introduces a create functionality to allow users to create new Queues and Jobs through a user-friendly dialog interface.

Key Features
Added a CreateQueueDialog component for creating new Queues.

Integrated a Floating Action Button (FAB) to trigger the dialog from the SearchBar.

Users can now enter:

name

required weights

Reclaimable

Guaranteed

capability and deserved resources

@Shrutim1505
Copy link
Member Author

this PR is behind #80 .
cc: @JesseStutler @Monokaix

@Shrutim1505
Copy link
Member Author

/assign @Monokaix

@Shrutim1505
Copy link
Member Author

image

@Monokaix
Copy link
Member

sorry my mistake, Queue is a cluster scope resource and has no namespace, and we can remove namespace.
And besides cpu and memory, we should Add a button of "+" and then users can set their custom scalar resources.

@Shrutim1505
Copy link
Member Author

ok @Monokaix I will update that one

@Shrutim1505
Copy link
Member Author

image

@Shrutim1505
Copy link
Member Author

Shrutim1505 commented May 18, 2025

@Monokaix we can add here custom scalar resources
and removed namespace filed also

@Shrutim1505 Shrutim1505 force-pushed the create-functionality branch from a2c9511 to 75d5c92 Compare May 18, 2025 05:48
@karanBRAVO
Copy link
Member

Hello @Shrutim1505, will you be creating separate PR for backend part?

@Shrutim1505
Copy link
Member Author

Hello @Shrutim1505, will you be creating separate PR for backend part?

yes

@Shrutim1505
Copy link
Member Author

Hello @Shrutim1505, will you be creating separate PR for backend part?

yes , already Did just need to open the PR

@Shrutim1505
Copy link
Member Author

Hello @Shrutim1505, will you be creating separate PR for backend part?

u can suggest frontend enhanacement for this functionality

@Shrutim1505 Shrutim1505 force-pushed the create-functionality branch from 75d5c92 to 365e64b Compare May 18, 2025 18:28
@karanBRAVO
Copy link
Member

karanBRAVO commented May 18, 2025

I think we can add a separate route for create, like /<job>/create.

@Monokaix
Copy link
Member

@Monokaix we can add here custom scalar resources and removed namespace filed also

Great job!

@Monokaix
Copy link
Member

image And the reclaimable should be selected by default.

@JesseStutler
Copy link
Member

@Shrutim1505 Custom Scaler Resources are part of capability/deserved/guarantee, not the same level as them, Custom Scaler Resources are optional and filled in as key-value pairs, e.g. nvidia.gpu: 2

@Shrutim1505
Copy link
Member Author

@Shrutim1505
Copy link
Member Author

i guess this one is fine @JesseStutler
image

@Shrutim1505
Copy link
Member Author

image

@Shrutim1505 Shrutim1505 force-pushed the create-functionality branch from b2760a2 to e64fc0d Compare May 22, 2025 12:48
@Shrutim1505 Shrutim1505 force-pushed the create-functionality branch 2 times, most recently from f478695 to 8aebbff Compare May 24, 2025 14:08
@Shrutim1505
Copy link
Member Author

Shrutim1505 commented May 24, 2025

image

please check now @JesseStutler is this fine ?? i did necesaary changes as said

@Shrutim1505 Shrutim1505 force-pushed the create-functionality branch from 766212a to ca22a65 Compare May 24, 2025 14:23
@Shrutim1505
Copy link
Member Author

image

@JesseStutler
Copy link
Member

Have you changed the + button to be like Create a queue button? Or else message, I think it may be more informational?

@Shrutim1505
Copy link
Member Author

yes @JesseStutler
image

@Shrutim1505 Shrutim1505 force-pushed the create-functionality branch 6 times, most recently from ff4727d to 363f4f2 Compare May 24, 2025 15:47
@Shrutim1505
Copy link
Member Author

i will resolve and push

@Shrutim1505 Shrutim1505 force-pushed the create-functionality branch 3 times, most recently from d065a9b to f59cc74 Compare May 24, 2025 16:34
Signed-off-by: Shrutim1505 <[email protected]>

WIP: local changes to package-lock.json

package.json

Signed-off-by: Shrutim1505 <[email protected]>

formatting checker

Signed-off-by: Shrutim1505 <[email protected]>

format check

Signed-off-by: Shrutim1505 <[email protected]>
@JesseStutler
Copy link
Member

Did you actually test? I created a queue and nothing happened, no new queue was created.

@Shrutim1505
Copy link
Member Author

yes i tested,
@JesseStutler this is just frontend...
for backend please check #152

@JesseStutler
Copy link
Member

/lgtm

@JesseStutler
Copy link
Member

yes i tested, @JesseStutler this is just frontend... for backend please check #152

OK

@Monokaix
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 08a0f8f into volcano-sh:main May 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants