-
Notifications
You must be signed in to change notification settings - Fork 49
Frontend: Create Functionality for Pods/Queues and Jobs #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend: Create Functionality for Pods/Queues and Jobs #88
Conversation
this PR is behind #80 . |
/assign @Monokaix |
47a95ea
to
7b71dfa
Compare
6512727
to
7550fcf
Compare
sorry my mistake, Queue is a cluster scope resource and has no namespace, and we can remove namespace. |
ok @Monokaix I will update that one |
@Monokaix we can add here custom scalar resources |
a2c9511
to
75d5c92
Compare
Hello @Shrutim1505, will you be creating separate PR for backend part? |
yes |
|
u can suggest frontend enhanacement for this functionality |
75d5c92
to
365e64b
Compare
I think we can add a separate |
Great job! |
@Shrutim1505 Custom Scaler Resources are part of capability/deserved/guarantee, not the same level as them, Custom Scaler Resources are optional and filled in as key-value pairs, e.g. nvidia.gpu: 2 |
ok i will check it once |
i guess this one is fine @JesseStutler |
b2760a2
to
e64fc0d
Compare
f478695
to
8aebbff
Compare
please check now @JesseStutler is this fine ?? i did necesaary changes as said |
766212a
to
ca22a65
Compare
Have you changed the |
yes @JesseStutler |
ff4727d
to
363f4f2
Compare
i will resolve and push |
d065a9b
to
f59cc74
Compare
Signed-off-by: Shrutim1505 <[email protected]> WIP: local changes to package-lock.json package.json Signed-off-by: Shrutim1505 <[email protected]> formatting checker Signed-off-by: Shrutim1505 <[email protected]> format check Signed-off-by: Shrutim1505 <[email protected]>
76131d3
to
c1ccbf9
Compare
Did you actually test? I created a queue and nothing happened, no new queue was created. |
yes i tested, |
/lgtm |
OK |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR introduces a create functionality to allow users to create new Queues and Jobs through a user-friendly dialog interface.
Key Features
Added a CreateQueueDialog component for creating new Queues.
Integrated a Floating Action Button (FAB) to trigger the dialog from the SearchBar.
Users can now enter:
name
required weights
Reclaimable
Guaranteed
capability and deserved resources