Skip to content

Conversation

Shrutim1505
Copy link
Member

@Shrutim1505 Shrutim1505 commented May 25, 2025

Description:

Added POST /api/queues endpoint
Enables creation of new Volcano Queue resources.

Validates incoming queue manifests.

Merges custom annotations into the metadata.

Logs Kubernetes API errors for better debugging.

🧩 Added POST /api/jobs endpoint
Allows creation of Volcano Jobs by submitting a complete YAML manifest.

Ensures metadata.namespace is always set (defaults to "default" if not provided).

Rejects invalid job manifests or requests using the "All" namespace.

Provides detailed error messages and Kubernetes API response logs for troubleshooting.

Job Deletion Support
Adds backend logic to delete Volcano jobs by name.

Ensures the jobs list is updated post-deletion.

@Shrutim1505
Copy link
Member Author

this pr is behind #88 , please approve it @JesseStutler @Monokaix

@Shrutim1505
Copy link
Member Author

/assign @kevin-wangzefeng

@Shrutim1505
Copy link
Member Author

cc : @JesseStutler @Monokaix

@Shrutim1505 Shrutim1505 force-pushed the backend-create branch 4 times, most recently from 4bed1cc to 57b233c Compare May 26, 2025 06:47
}

alert("Queue created successfully!");
await fetchQueues();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the API response includes the full created resource, we could update local state directly and skip fetchData() to reduce extra network calls. @Shrutim1505
// @Monokaix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @de6p

@Shrutim1505 Shrutim1505 force-pushed the backend-create branch 5 times, most recently from 41ff3ae to ce6d595 Compare May 26, 2025 07:21
@Shrutim1505
Copy link
Member Author

Shrutim1505 commented May 26, 2025

cc: @Monokaix @JesseStutler please approve this

@JesseStutler
Copy link
Member

Still can't create queues, here are the console logs when I tried to create a queue:
image

Please test in your local environment completely and then ping us(With a video is better)

@Shrutim1505 Shrutim1505 force-pushed the backend-create branch 6 times, most recently from fe2c965 to dd7e2c0 Compare May 27, 2025 21:55
@Shrutim1505
Copy link
Member Author

image
please check , guaranteed typo solved to guarantee @JesseStutler
this pr is mergeable

@Shrutim1505 Shrutim1505 force-pushed the backend-create branch 2 times, most recently from bed5bc7 to 3652207 Compare May 27, 2025 22:42
@Shrutim1505 Shrutim1505 changed the title Add API Endpoints for Queue, Jobs and Pods Creation with Namespace Handling Backend support : Add API Endpoints for Queue Creation with Namespace Handling May 27, 2025
@Shrutim1505
Copy link
Member Author

cc : @JesseStutler

@Shrutim1505 Shrutim1505 changed the title Backend support : Add API Endpoints for Queue Creation with Namespace Handling Backend support : Add API Endpoints for Queue Creation and jobs with Namespace Handling May 29, 2025
@Shrutim1505
Copy link
Member Author

Screen.Recording.2025-05-29.100723.mp4

@Shrutim1505 Shrutim1505 changed the title Backend support : Add API Endpoints for Queue Creation and jobs with Namespace Handling Backend support : Add API Endpoints for Queue/Job Creation and deletion of jobs May 29, 2025
@Shrutim1505
Copy link
Member Author

@JesseStutler this pr handles job deletion also

@Shrutim1505
Copy link
Member Author

@Monokaix @JesseStutler Tested it locally on docker too
image
image

@Monokaix
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JesseStutler
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot merged commit 233b607 into volcano-sh:main May 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants