Skip to content

Troubleshoot failing macos check on CI #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2022
Merged

Troubleshoot failing macos check on CI #1191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b76f5e3
Update to `actions/setup-python@v4`
jtpio Aug 26, 2022
8256ad1
Switch to `bash -e {0}`
jtpio Aug 26, 2022
99d1d44
Install `jupyterlab~=3.0 notebook~=6.5` to test extensions
jtpio Aug 26, 2022
c151ced
Install notebook 6.4 on CI
jtpio Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:
- uses: actions/checkout@v2

- name: Set up Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/packaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:

defaults:
run:
shell: bash -l {0}
shell: bash -e {0}

jobs:
build:
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
py_cmd: python
steps:
- name: Install Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python }}
architecture: 'x64'
Expand All @@ -82,7 +82,7 @@ jobs:
path: ./dist
- name: Install the prerequisites
run: |
${{ matrix.py_cmd }} -m pip install pip wheel
${{ matrix.py_cmd }} -m pip install pip wheel jupyterlab~=3.0 notebook~=6.4
Copy link
Member Author

@jtpio jtpio Aug 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how the extension checks below could have worked before without these packages 🤔

- name: Install the package
run: |
cd dist
Expand Down