Skip to content

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Aug 26, 2022

References

Continuation of #1190

Code changes

CI fixes.

User-facing changes

None

Backwards-incompatible changes

None

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/voila/fix-ci

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 117 <- [133 - 161 - 209] -> 371 128 <- [145 - 173 - 238] -> 413 558 <- [684 - 899 - 1323] -> 2592 182 <- [216 - 270 - 380] -> 693 2224 <- [2305 - 2433 - 3172] -> 6128 2330 <- [2406 - 2480 - 2624] -> 3041 2428 <- [2439 - 2472 - 2477] -> 2846 2495 <- [2559 - 2565 - 2646] -> 2941 2125 <- [2185 - 2323 - 2609] -> 3613 3199 <- [3288 - 3405 - 3665] -> 4525 7225 <- [8226 - 8523 - 9319] -> 9337 5886 <- [5991 - 6024 - 6049] -> 6067 1336 <- [1360 - 1385 - 1408] -> 1445 3667 <- [3971 - 4596 - 5911] -> 9757
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-08-26 11:10:13.536315270 +0000
+++ /dev/fd/62	2022-08-26 11:10:13.536315270 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8272CL",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "85",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "7",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281307648
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1017-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.4 LTS",
-      "serial": "d6312db80b0c4ba59b8da84ab4b2952b",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@jtpio
Copy link
Member Author

jtpio commented Aug 26, 2022

OK so all the tests are now failing, this looks new...

But the macos install check now passes:

image

With the correct Python version now being used across steps:

image

- name: Install the prerequisites
run: |
${{ matrix.py_cmd }} -m pip install pip wheel
${{ matrix.py_cmd }} -m pip install pip wheel jupyterlab~=3.0 notebook~=6.4
Copy link
Member Author

@jtpio jtpio Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how the extension checks below could have worked before without these packages 🤔

@jtpio jtpio mentioned this pull request Aug 26, 2022
@jtpio
Copy link
Member Author

jtpio commented Aug 26, 2022

Marking as ready as this at least fixes the macos install check.

The other failures still need a fix too but they look unrelated to this change: #1192 (comment)

@jtpio jtpio marked this pull request as ready for review August 26, 2022 12:35
@trungleduc
Copy link
Member

Thanks @jtpio !

@trungleduc trungleduc merged commit 636e1d9 into voila-dashboards:main Aug 29, 2022
@jtpio jtpio deleted the fix-ci branch August 29, 2022 14:48
@trungleduc trungleduc mentioned this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants