Skip to content

[Bugfix][FailingTest]Fix test_model_load_with_params.py #18758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

[Bugfix][FailingTest]Fix test_model_load_with_params.py #18758

merged 1 commit into from
May 28, 2025
+19 −22

Conversation

rabi
Copy link
Contributor

@rabi rabi commented May 27, 2025 •
edited by github-actions bot
Loading

Fixes number of issues with the tests.

FIX: #18757

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 27, 2025
@rabi rabi force-pushed the 18757 branch 2 times, most recently from a4a2803 to 2c6d01c Compare May 27, 2025 10:10
DarkLight1337
DarkLight1337 reviewed May 27, 2025
View reviewed changes
@rabi rabi force-pushed the 18757 branch 2 times, most recently from efe9f81 to 54984dd Compare May 27, 2025 10:31
DarkLight1337
DarkLight1337 reviewed May 27, 2025
View reviewed changes
DarkLight1337
DarkLight1337 reviewed May 27, 2025
View reviewed changes
@rabi
[Bugfix][FailingTest]Fix test_model_load_with_params.py
e1e93ec 
Also adds a new buildkite step to run all  model_executor tests.

FIX: vllm-project#18757
Signed-off-by: rabi <[email protected]>
DarkLight1337
DarkLight1337 approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 28, 2025 02:34
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 28, 2025
@DarkLight1337 DarkLight1337 merged commit b78f844 into vllm-project:main May 28, 2025
96 of 98 checks passed
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@rabi @amitm02
[Bugfix][FailingTest]Fix test_model_load_with_params.py (vllm-project…
4c1993e 
…#18758)

Signed-off-by: rabi <[email protected]>
Signed-off-by: amit <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@rabi @minpeter
[Bugfix][FailingTest]Fix test_model_load_with_params.py (vllm-project…
8609f25 
…#18758)

Signed-off-by: rabi <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: model_executor/test_model_load_with_params.py fails with AttributeError
3 participants
@rabi @mgoin @DarkLight1337