Skip to content

Commit 8609f25

Browse files
rabiminpeter
authored andcommitted
[Bugfix][FailingTest]Fix test_model_load_with_params.py (vllm-project#18758)
Signed-off-by: rabi <[email protected]> Signed-off-by: minpeter <[email protected]>
1 parent 751cb7e commit 8609f25

File tree

4 files changed

+19
-22
lines changed

4 files changed

+19
-22
lines changed

.buildkite/test-pipeline.yaml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -274,17 +274,6 @@ steps:
274274
- pytest -v -s samplers
275275
- VLLM_USE_FLASHINFER_SAMPLER=1 pytest -v -s samplers
276276

277-
- label: LogitsProcessor Test # 5min
278-
mirror_hardwares: [amdexperimental, amdproduction]
279-
source_file_dependencies:
280-
- vllm/model_executor/layers
281-
- vllm/model_executor/guided_decoding
282-
- tests/test_logits_processor
283-
- tests/model_executor/test_guided_processors
284-
commands:
285-
- pytest -v -s test_logits_processor.py
286-
- pytest -v -s model_executor/test_guided_processors.py
287-
288277
- label: Speculative decoding tests # 40min
289278
mirror_hardwares: [amdexperimental]
290279
source_file_dependencies:
@@ -397,6 +386,17 @@ steps:
397386
- pytest -v -s tensorizer_loader
398387
- pytest -v -s entrypoints/openai/test_tensorizer_entrypoint.py
399388

389+
- label: Model Executor Test
390+
mirror_hardwares: [amdexperimental, amdproduction]
391+
soft_fail: true
392+
source_file_dependencies:
393+
- vllm/model_executor
394+
- tests/model_executor
395+
commands:
396+
- apt-get update && apt-get install -y curl libsodium23
397+
- export VLLM_WORKER_MULTIPROC_METHOD=spawn
398+
- pytest -v -s model_executor
399+
400400
- label: Benchmarks # 9min
401401
mirror_hardwares: [amdexperimental, amdproduction]
402402
working_dir: "/vllm-workspace/.buildkite"

tests/model_executor/test_model_load_with_params.py

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import pytest
66

7-
from vllm.model_executor.layers.pooler import CLSPool, PoolingType
7+
from vllm.model_executor.layers.pooler import CLSPool, MeanPool, PoolingType
88
from vllm.model_executor.models.bert import BertEmbeddingModel
99
from vllm.model_executor.models.roberta import RobertaEmbeddingModel
1010
from vllm.platforms import current_platform
@@ -14,7 +14,7 @@
1414
REVISION = os.environ.get("REVISION", "main")
1515

1616
MODEL_NAME_ROBERTA = os.environ.get("MODEL_NAME",
17-
"intfloat/multilingual-e5-small")
17+
"intfloat/multilingual-e5-base")
1818
REVISION_ROBERTA = os.environ.get("REVISION", "main")
1919

2020

@@ -40,17 +40,15 @@ def test_model_loading_with_params(vllm_runner):
4040

4141
# asserts on the pooling config files
4242
assert model_config.pooler_config.pooling_type == PoolingType.CLS.name
43-
assert model_config.pooler_config.pooling_norm
43+
assert model_config.pooler_config.normalize
4444

4545
# asserts on the tokenizer loaded
4646
assert model_tokenizer.tokenizer_id == "BAAI/bge-base-en-v1.5"
47-
assert model_tokenizer.tokenizer_config["do_lower_case"]
4847
assert model_tokenizer.tokenizer.model_max_length == 512
4948

5049
def check_model(model):
5150
assert isinstance(model, BertEmbeddingModel)
52-
assert model._pooler.pooling_type == PoolingType.CLS
53-
assert model._pooler.normalize
51+
assert isinstance(model._pooler, CLSPool)
5452

5553
vllm_model.apply_model(check_model)
5654

@@ -80,16 +78,15 @@ def test_roberta_model_loading_with_params(vllm_runner):
8078

8179
# asserts on the pooling config files
8280
assert model_config.pooler_config.pooling_type == PoolingType.MEAN.name
83-
assert model_config.pooler_config.pooling_norm
81+
assert model_config.pooler_config.normalize
8482

8583
# asserts on the tokenizer loaded
86-
assert model_tokenizer.tokenizer_id == "intfloat/multilingual-e5-small"
87-
assert not model_tokenizer.tokenizer_config["do_lower_case"]
84+
assert model_tokenizer.tokenizer_id == "intfloat/multilingual-e5-base"
85+
assert model_tokenizer.tokenizer.model_max_length == 512
8886

8987
def check_model(model):
9088
assert isinstance(model, RobertaEmbeddingModel)
91-
assert model._pooler.pooling_type == PoolingType.MEAN
92-
assert model._pooler.normalize
89+
assert isinstance(model._pooler, MeanPool)
9390

9491
vllm_model.apply_model(check_model)
9592

0 commit comments

Comments
 (0)