-
Notifications
You must be signed in to change notification settings - Fork 21
Add CB API tests on the correct use of max_tokens #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,9 @@ | |
""" | ||
|
||
import pytest | ||
from spyre_util import (generate_spyre_vllm_output, get_chicken_soup_prompts, | ||
get_spyre_model_list) | ||
from openai import BadRequestError | ||
from spyre_util import (RemoteOpenAIServer, generate_spyre_vllm_output, | ||
get_chicken_soup_prompts, get_spyre_model_list) | ||
from vllm import SamplingParams | ||
|
||
|
||
|
@@ -44,6 +45,64 @@ def test_cb_max_tokens( | |
monkeypatch=monkeypatch) | ||
|
||
|
||
@pytest.mark.cb | ||
@pytest.mark.parametrize("cb", [True]) | ||
@pytest.mark.parametrize("model", get_spyre_model_list()) | ||
@pytest.mark.parametrize("max_model_len", [256]) | ||
@pytest.mark.parametrize("max_num_seqs", [2]) | ||
@pytest.mark.parametrize( | ||
"backend", [pytest.param("eager", marks=pytest.mark.cpu, id="eager")]) | ||
def test__api_cb_rejects_oversized_request( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is that an extra There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh yes, does that prevent it from running? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nope, it did run successfully - https://github.com/vllm-project/vllm-spyre/actions/runs/16602263437/job/46964891318?pr=339#step:11:47 Just a formatting issue |
||
remote_openai_server: RemoteOpenAIServer, | ||
model: str, | ||
backend: str, | ||
cb: bool, | ||
max_model_len: int, | ||
max_num_seqs: int, | ||
): | ||
"""Verify API rejects request that exceed max_model_len with CB enabled""" | ||
|
||
client = remote_openai_server.get_client() | ||
overflow_prompt = " ".join(["hi"] * max_model_len) | ||
max_tokens = 10 | ||
|
||
with pytest.raises(BadRequestError, | ||
match="This model's maximum context length is"): | ||
client.completions.create( | ||
model=model, | ||
prompt=overflow_prompt, | ||
max_tokens=max_tokens, | ||
) | ||
|
||
|
||
@pytest.mark.cb | ||
@pytest.mark.parametrize("cb", [True]) | ||
@pytest.mark.parametrize("model", get_spyre_model_list()) | ||
@pytest.mark.parametrize("max_model_len", [256]) | ||
@pytest.mark.parametrize("max_num_seqs", [2]) | ||
@pytest.mark.parametrize( | ||
"backend", [pytest.param("eager", marks=pytest.mark.cpu, id="eager")]) | ||
def test_api_cb_generates_correct_max_tokens( | ||
remote_openai_server: RemoteOpenAIServer, | ||
model: str, | ||
backend: str, | ||
cb: bool, | ||
max_model_len: int, | ||
max_num_seqs: int, | ||
): | ||
"""Verify API generates the correct numbers of tokens with CB enabled""" | ||
|
||
client = remote_openai_server.get_client() | ||
max_tokens = 10 | ||
|
||
response = client.completions.create(model=model, | ||
prompt=get_chicken_soup_prompts(1), | ||
max_tokens=max_tokens, | ||
temperature=0) | ||
|
||
assert response.usage.completion_tokens == max_tokens | ||
|
||
|
||
@pytest.mark.cb | ||
@pytest.mark.spyre | ||
@pytest.mark.xfail # TODO: remove once a spyre-base image supports this | ||
|
Uh oh!
There was an error while loading. Please reload this page.