Add CB API tests on the correct use of max_tokens #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Marinho <[email protected]>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. Or this can be done with Now you are good to go 🚀 |
Signed-off-by: Gabriel Marinho <[email protected]>
Signed-off-by: Gabriel Marinho <[email protected]>
Signed-off-by: Gabriel Marinho <[email protected]>
gmarinho2
changed the title
Signed-off-by: Gabriel Marinho <[email protected]>
ckadner
requested changes
Jul 28, 2025
maxdebayser
reviewed
Jul 29, 2025
Signed-off-by: Gabriel Marinho <[email protected]>
gmarinho2
requested review from
rafvasq,
prashantgupta24 and
sducouedic
as code owners
maxdebayser
approved these changes
Jul 29, 2025
ckadner
approved these changes
Jul 29, 2025
| @pytest.mark.parametrize("max_num_seqs", [2]) | ||
| @pytest.mark.parametrize( | ||
| "backend", [pytest.param("eager", marks=pytest.mark.cpu, id="eager")]) | ||
| def test__api_cb_rejects_oversized_request( |
There was a problem hiding this comment.
is that an extra _ between test and api?
There was a problem hiding this comment.
Oh yes, does that prevent it from running?
There was a problem hiding this comment.
Nope, it did run successfully - https://github.com/vllm-project/vllm-spyre/actions/runs/16602263437/job/46964891318?pr=339#step:11:47
Just a formatting issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests to check if the API is generating the correct amount of tokens when CB is enabled.
Related Issues